Bump org.jenkins-ci.plugins:plugin from 5.8 to 5.9 (#1658)

* Bump org.jenkins-ci.plugins:plugin from 5.8 to 5.9

Bumps [org.jenkins-ci.plugins:plugin](https://github.com/jenkinsci/plugin-pom) from 5.8 to 5.9.
- [Release notes](https://github.com/jenkinsci/plugin-pom/releases)
- [Changelog](https://github.com/jenkinsci/plugin-pom/blob/master/CHANGELOG.md)
- [Commits](jenkinsci/plugin-pom@plugin-5.8...plugin-5.9)

---
updated-dependencies:
- dependency-name: org.jenkins-ci.plugins:plugin
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

* Clean up SpotBugs suppressions

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Vincent Latombe <[email protected]>

Author: dependabot[bot]

pom.xml

@@ -4,7 +4,7 @@
   <parent>
     <groupId>org.jenkins-ci.plugins</groupId>
     <artifactId>plugin</artifactId>
-    <version>5.8</version>
+    <version>5.9</version>
     <relativePath />
   </parent>
 

src/main/java/org/csanchez/jenkins/plugins/kubernetes/KubernetesCloud.java

@@ -10,7 +10,6 @@
 import com.cloudbees.plugins.credentials.domains.URIRequirementBuilder;
 import edu.umd.cs.findbugs.annotations.CheckForNull;
 import edu.umd.cs.findbugs.annotations.NonNull;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import hudson.Extension;
 import hudson.Main;
 import hudson.TcpSlaveAgentListener;
@@ -188,11 +187,6 @@ public KubernetesCloud(String name) {
      * @param source Source Kubernetes cloud implementation
      * @since 0.13
      */
-    @SuppressFBWarnings(
-            value = "MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR",
-            justification = "Problem raised for calling unmarshal. Ignoring the "
-                    + "warning cause it leads to too many changes, with "
-                    + "unclear impact.")
     public KubernetesCloud(@NonNull String name, @NonNull KubernetesCloud source) {
         super(name);
         XStream2 xs = new XStream2();
@@ -592,7 +586,6 @@ public void setPodRetention(PodRetention podRetention) {
      *
      * @return Kubernetes client.
      */
-    @SuppressFBWarnings({"IS2_INCONSISTENT_SYNC", "DC_DOUBLECHECK"})
     public KubernetesClient connect() throws KubernetesAuthException, IOException {
 
         LOGGER.log(Level.FINEST, "Building connection to Kubernetes {0} URL {1} namespace {2}", new String[] {

src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodTemplate.java

@@ -2,7 +2,6 @@
 
 import edu.umd.cs.findbugs.annotations.CheckForNull;
 import edu.umd.cs.findbugs.annotations.NonNull;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import hudson.Extension;
 import hudson.Util;
 import hudson.model.AbstractDescribableImpl;
@@ -258,11 +257,6 @@ public PodTemplate(@CheckForNull String id) {
         recomputeLabelDerivedFields();
     }
 
-    @SuppressFBWarnings(
-            value = "MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR",
-            justification = "Warning raised for the call to unmarshal. Ignoring as"
-                    + " it would require too many changes and uncertain "
-                    + "impact.")
     public PodTemplate(PodTemplate from) {
         XStream2 xs = new XStream2();
         xs.unmarshal(XStream2.getDefaultDriver().createReader(new StringReader(xs.toXML(from))), this);
@@ -276,10 +270,6 @@ public PodTemplate(String image, List<? extends PodVolume> volumes) {
         this(null, image, volumes);
     }
 
-    @SuppressFBWarnings(
-            value = "MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR",
-            justification = "Warning raised for calling the getContainers method. As "
-                    + "this current method is deprecated anyway, it is " + "probably safer to not change it.")
     @Deprecated
     PodTemplate(String name, String image, List<? extends PodVolume> volumes) {
         this(name, volumes, Collections.emptyList());
@@ -367,9 +357,6 @@ public void setRemoteFs(String remoteFs) {
     }
 
     @Deprecated
-    @SuppressFBWarnings(
-            value = "NM_CONFUSING",
-            justification = "Naming confusion with a getRemoteFS method, but the current one is deprecated.")
     public String getRemoteFs() {
         return getFirstContainer().map(ContainerTemplate::getWorkingDir).orElse(ContainerTemplate.DEFAULT_WORKING_DIR);
     }
@@ -851,7 +838,7 @@ public void setContainers(@NonNull List<ContainerTemplate> items) {
     }
 
     @NonNull
-    public List<ContainerTemplate> getContainers() {
+    public final List<ContainerTemplate> getContainers() {
         if (containers == null) {
             return Collections.emptyList();
         }

src/main/java/org/csanchez/jenkins/plugins/kubernetes/PodTemplateBuilder.java

@@ -33,7 +33,6 @@
 
 import edu.umd.cs.findbugs.annotations.CheckForNull;
 import edu.umd.cs.findbugs.annotations.NonNull;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import hudson.TcpSlaveAgentListener;
 import hudson.Util;
 import hudson.slaves.SlaveComputer;
@@ -107,7 +106,6 @@ public class PodTemplateBuilder {
     private static final String JENKINS_AGENT_FILE_ENVVAR = "JENKINS_AGENT_FILE";
     private static final String JENKINS_AGENT = "/jenkins-agent";
 
-    @SuppressFBWarnings(value = "MS_SHOULD_BE_FINAL", justification = "tests")
     @Restricted(NoExternalUse.class)
     static String DEFAULT_JNLP_DOCKER_REGISTRY_PREFIX =
             System.getProperty(PodTemplateStepExecution.class.getName() + ".dockerRegistryPrefix");

src/main/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/PodTemplateAction.java

@@ -1,7 +1,6 @@
 package org.csanchez.jenkins.plugins.kubernetes.pipeline;
 
 import edu.umd.cs.findbugs.annotations.NonNull;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import hudson.BulkChange;
 import hudson.model.Run;
 import java.io.IOException;
@@ -31,7 +30,6 @@ protected static void push(@NonNull Run<?, ?> run, @NonNull String item) throws
     }
 
     @Deprecated
-    @SuppressFBWarnings("DLS_DEAD_LOCAL_STORE")
     public void push(String template) throws IOException {
         if (run == null) {
             LOGGER.warning("run is null, cannot push");

src/main/java/org/csanchez/jenkins/plugins/kubernetes/pod/retention/Reaper.java

@@ -371,10 +371,6 @@ public void onClose(WatcherException e) {
      * @param node a {@link Node#getNodeName}
      * @return a possibly empty set of {@link ContainerStateTerminated#getReason} or {@link PodStatus#getReason}
      */
-    @SuppressFBWarnings(
-            value = "NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE",
-            justification =
-                    "Confused by @org.checkerframework.checker.nullness.qual.Nullable on LoadingCache.get? Never null here.")
     @NonNull
     public Set<String> terminationReasons(@NonNull String node) {
         synchronized (terminationReasons) {