Mark DynamicPVC as deprecated

Author: Vlatombe

src/main/java/org/csanchez/jenkins/plugins/kubernetes/volumes/DynamicPVCVolume.java

@@ -22,10 +22,13 @@
 
 /**
  * Implements a dynamic PVC volume, that is created before the agent pod is created, and terminated afterwards.
+ *
+ * @deprecated Use {@link GenericEphemeralVolume} instead.
  */
 @SuppressFBWarnings(
         value = "SE_NO_SERIALVERSIONID",
         justification = "Serialization happens exclusively through XStream and not Java Serialization.")
+@Deprecated
 public class DynamicPVCVolume extends PodVolume implements DynamicPVC {
     private String id;
     private String storageClassName;
@@ -109,12 +112,12 @@ public int hashCode() {
         return Objects.hash(id, storageClassName, requestsSize, accessModes);
     }
 
-    @Extension
+    @Extension(ordinal = -100) // Display at the end of the select list
     @Symbol("dynamicPVC")
     public static class DescriptorImpl extends Descriptor<PodVolume> {
         @Override
         public String getDisplayName() {
-            return "Dynamic Persistent Volume Claim";
+            return "Dynamic Persistent Volume Claim (deprecated)";
         }
 
         @SuppressWarnings("unused") // by stapler

src/main/java/org/csanchez/jenkins/plugins/kubernetes/volumes/workspace/DynamicPVCWorkspaceVolume.java

@@ -23,10 +23,13 @@
 
 /**
  * @author <a href="[email protected]">runzexia</a>
+ *
+ * @deprecated Use {@link GenericEphemeralWorkspaceVolume} instead.
  */
 @SuppressFBWarnings(
         value = "SE_NO_SERIALVERSIONID",
         justification = "Serialization happens exclusively through XStream and not Java Serialization.")
+@Deprecated
 public class DynamicPVCWorkspaceVolume extends WorkspaceVolume implements DynamicPVC {
     private String storageClassName;
     private String requestsSize;
@@ -95,12 +98,12 @@ public int hashCode() {
         return Objects.hash(storageClassName, requestsSize, accessModes);
     }
 
-    @Extension
+    @Extension(ordinal = -100) // Display at the end of the select list
     @Symbol("dynamicPVC")
     public static class DescriptorImpl extends Descriptor<WorkspaceVolume> {
         @Override
         public String getDisplayName() {
-            return "Dynamic Persistent Volume Claim";
+            return "Dynamic Persistent Volume Claim (deprecated)";
         }
 
         @SuppressWarnings("unused") // by stapler

src/main/resources/org/csanchez/jenkins/plugins/kubernetes/volumes/DynamicPVCVolume/config.jelly

@@ -2,8 +2,11 @@
 <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout"
          xmlns:t="/lib/hudson" xmlns:f="/lib/form">
     <f:description>
+        <em>This feature is deprecated. Please use generic ephemeral volume instead, which provides the same functionality without requiring explicit RBAC permissions to create persistent volume claims.</em>
+        <p>
         Allocates a PVC dynamically using the specified parameters, then deletes it when the pod is deleted.
         Note that this requires the Jenkins controller to have additional RBAC permissions than are typically needed for agent provisioning.
+        </p>
     </f:description>
 
     <f:entry title="${%Mount path}" field="mountPath">

src/main/resources/org/csanchez/jenkins/plugins/kubernetes/volumes/workspace/DynamicPVCWorkspaceVolume/config.jelly

@@ -2,8 +2,11 @@
 <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout"
          xmlns:t="/lib/hudson" xmlns:f="/lib/form">
     <f:description>
+        <em>This feature is deprecated. Please use generic ephemeral volume instead, which provides the same functionality without requiring explicit RBAC permissions to create persistent volume claims.</em>
+        <p>
         Allocates a PVC dynamically using the specified parameters, then deletes it when the pod is deleted.
         Note that this requires the Jenkins controller to have additional RBAC permissions than are typically needed for agent provisioning.
+        </p>
     </f:description>
 
     <f:entry title="${%Storage Class Name}" field="storageClassName">