Add ability to do custom check on a device when locking

[asadniazi]

What feature do you want to see added?

I t would be nice to be able to do some checks on the device when picking a device from the pool e.g. ping test, ssh/telnet login test to ensure the device is in usable state. developer should be able to provide and point to a piece of code to be used to check if the device is in good state before logging.

Possible flow could be:

1. Lock a resource
2. Run the provided device check code
3. Continue of the code returns True,
4. Else, try the next available resource from the pool
5. If none found abort/fail the build with proper error message

Upstream changes

No response

Are you interested in contributing this feature?

No response

[valliman]

Hi,

we have a similar use case that could be addressed with this.

We have 4 resources with the same label, and sometimes, the first one with that label breaks down. Unfortunately, the locking algorithm always takes the first resource with a specific label, so we end up with pipelines failing, although we would have 3 more resources available.

@mPokornyETM the custom check can be a solution for us as well. Alternatively, some more randomness when locking resources; I've checked the documentation but did not find a setting to change the locking strategy/behavior.

[mPokornyETM]

Hi,

we have a similar use case that could be addressed with this.

We have 4 resources with the same label, and sometimes, the first one with that label breaks down. Unfortunately, the locking algorithm always takes the first resource with a specific label, so we end up with pipelines failing, although we would have 3 more resources available.

@mPokornyETM the custom check can be a solution for us as well. Alternatively, some more randomness when locking resources; I've checked the documentation but did not find a setting to change the locking strategy/behavior.

To eliminate this scenario you can make this magci.
Just add a label 'broken' via groovy on demand and extend the label filter to yourLabel && !broken