Skip to content

Commit 1d30ac3

Browse files
Require 2.479.1 or newer
1 parent e3dd8d3 commit 1d30ac3

File tree

5 files changed

+26
-17
lines changed

5 files changed

+26
-17
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,10 @@ jobs:
1717
steps:
1818
- name: Checkout
1919
uses: actions/checkout@v2
20-
- name: Set up JDK 11
20+
- name: Set up JDK 17
2121
uses: actions/setup-java@v1
2222
with:
23-
java-version: 11
23+
java-version: 17
2424
- name: Build with Maven
2525
run: mvn -B -Dgpg.skip jacoco:prepare-agent verify jacoco:report
2626
- name: Upload code coverage

Jenkinsfile

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,12 @@
1-
buildPlugin(useContainerAgent: true, timeout: 180, configurations: [
2-
[platform: 'linux', jdk: 17],
3-
[platform: 'windows', jdk: 11],
4-
])
1+
/*
2+
See the documentation for more options:
3+
https://github.com/jenkins-infra/pipeline-library/
4+
*/
5+
buildPlugin(
6+
forkCount: '1C', // run this number of tests in parallel for faster feedback. If the number terminates with a 'C', the value will be multiplied by the number of available CPU cores
7+
useContainerAgent: true, // Set to `false` if you need to use Docker for containerized tests
8+
timeout: 180,
9+
configurations: [
10+
[platform: 'linux', jdk: 21],
11+
[platform: 'windows', jdk: 17],
12+
])

pom.xml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<parent>
55
<groupId>org.jenkins-ci.plugins</groupId>
66
<artifactId>plugin</artifactId>
7-
<version>4.60</version>
7+
<version>5.9</version>
88
<relativePath />
99
</parent>
1010
<groupId>io.jenkins.plugins</groupId>
@@ -13,8 +13,9 @@
1313
<url>https://github.com/jenkinsci/${project.artifactId}-plugin/blob/main/README.md</url>
1414
<packaging>hpi</packaging>
1515
<properties>
16-
<jenkins.version>2.375.4</jenkins.version>
17-
<junit.junit.version>5.8.0</junit.junit.version>
16+
<jenkins.baseline>2.479</jenkins.baseline>
17+
<jenkins.version>${jenkins.baseline}.3</jenkins.version>
18+
<junit.junit.version>5.12.1</junit.junit.version>
1819
<jacoco.version>0.8.7</jacoco.version>
1920
</properties>
2021
<name>Multiselect parameter</name>

src/main/java/de/westemeyer/plugins/multiselect/MultiselectParameterDefinition.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
import org.kohsuke.stapler.DataBoundConstructor;
1212
import org.kohsuke.stapler.DataBoundSetter;
1313
import org.kohsuke.stapler.QueryParameter;
14-
import org.kohsuke.stapler.StaplerRequest;
14+
import org.kohsuke.stapler.StaplerRequest2;
1515
import org.kohsuke.stapler.bind.JavaScriptMethod;
1616
import org.kohsuke.stapler.verb.POST;
1717

@@ -149,7 +149,7 @@ public ParameterValue getDefaultParameterValue() {
149149
}
150150

151151
@Override
152-
public ParameterValue createValue(StaplerRequest staplerRequest, JSONObject jsonObject) {
152+
public ParameterValue createValue(StaplerRequest2 staplerRequest, JSONObject jsonObject) {
153153
return createValue(jsonObject);
154154
}
155155

@@ -187,7 +187,7 @@ public MultiselectParameterValue createValue(Map<String, Object> jsonObject) {
187187
}
188188

189189
@Override
190-
public ParameterValue createValue(StaplerRequest staplerRequest) {
190+
public ParameterValue createValue(StaplerRequest2 staplerRequest) {
191191
return getDefaultParameterValue();
192192
}
193193

@@ -277,7 +277,7 @@ public String getDisplayName() {
277277
}
278278

279279
@Override
280-
public ParameterDefinition newInstance(@Nullable StaplerRequest req, @Nonnull JSONObject formData) {
280+
public ParameterDefinition newInstance(@Nullable StaplerRequest2 req, @Nonnull JSONObject formData) {
281281
// currently only CSV configuration format is implemented
282282
MultiselectConfigurationFormat format = MultiselectConfigurationFormat.CSV;
283283

src/test/java/de/westemeyer/plugins/multiselect/MultiselectParameterDefinitionTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import org.junit.jupiter.api.Test;
99
import org.junit.jupiter.params.ParameterizedTest;
1010
import org.junit.jupiter.params.provider.CsvSource;
11-
import org.kohsuke.stapler.StaplerRequest;
11+
import org.kohsuke.stapler.StaplerRequest2;
1212

1313
import java.io.IOException;
1414
import java.util.Collections;
@@ -119,7 +119,7 @@ void getDefaultParameterValue() {
119119
@Test
120120
void createValue() {
121121
MultiselectParameterDefinition definition = new MultiselectParameterDefinition(NAME, DESCRIPTION, INPUT, CSV);
122-
ParameterValue defaultParameterValue = definition.createValue((StaplerRequest) null);
122+
ParameterValue defaultParameterValue = definition.createValue((StaplerRequest2) null);
123123
assertNotNull(defaultParameterValue);
124124
assertEquals(NAME, defaultParameterValue.getName());
125125
Object parameterValueContent = defaultParameterValue.getValue();
@@ -134,7 +134,7 @@ void createValue() {
134134
values.put("name", "Hugo");
135135
values.put("integer", 1);
136136
values.put("empty", "");
137-
MultiselectParameterValue value = (MultiselectParameterValue) definition.createValue(null, values);
137+
MultiselectParameterValue value = (MultiselectParameterValue) definition.createValue((StaplerRequest2) null, values);
138138
assertNotNull(value);
139139
EnvVars vars = new EnvVars();
140140
value.buildEnvironment(null, vars);
@@ -190,7 +190,7 @@ void newInstance() {
190190
jsonObject.put("name", "parametername");
191191
jsonObject.put("description", DESCRIPTION);
192192
MultiselectParameterDefinition.DescriptorImpl descriptor = new MultiselectParameterDefinition.DescriptorImpl();
193-
MultiselectParameterDefinition parameterDefinition = (MultiselectParameterDefinition) descriptor.newInstance(null, jsonObject);
193+
MultiselectParameterDefinition parameterDefinition = (MultiselectParameterDefinition) descriptor.newInstance((StaplerRequest2) null, jsonObject);
194194
MultiselectDecisionTree decisionTree = parameterDefinition.getDecisionTree();
195195
assertNotNull(decisionTree);
196196
assertEquals(definition.getDecisionTree().toString(), decisionTree.toString());

0 commit comments

Comments
 (0)