JENKINS-72139: Jenkins 2.426 compatibility

Author: swesteme

src/main/java/de/westemeyer/plugins/multiselect/MultiselectParameterDefinition.java

@@ -21,7 +21,7 @@
 import java.io.IOException;
 import java.util.ArrayDeque;
 import java.util.ArrayList;
-import java.util.Collections;
+import java.util.Arrays;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
@@ -110,7 +110,7 @@ public static Queue<Integer> createCoordinates(Integer... coordinates) {
         Queue<Integer> itemPath = new ArrayDeque<>();
 
         // add all items to queue
-        Collections.addAll(itemPath, coordinates);
+        Arrays.stream(coordinates).filter(Objects::nonNull).forEach(itemPath::add);
 
         // return queue object
         return itemPath;

src/main/resources/de/westemeyer/plugins/multiselect/MultiselectParameterDefinition/index.jelly

@@ -57,7 +57,7 @@
         function ${variable.uuid}Changed(select)
         {
             <j:if test="${i ne (variableDescriptions.size() - 1)}">
-            var coordinatesBuffer = new Array(${variableDescriptions.size()});
+                var coordinatesBuffer = new Array();
             var e = null;
                 <j:forEach var="listItem" items="${variableDescriptions}" indexVar="j">
                     <j:if test="${j lt (i + 1)}">

src/test/java/de/westemeyer/plugins/multiselect/MultiselectParameterDefinitionTest.java

@@ -10,6 +10,7 @@
 
 import java.io.IOException;
 import java.util.Collections;
+import java.util.Queue;
 
 import static de.westemeyer.plugins.multiselect.MultiselectConfigurationFormat.CSV;
 import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
@@ -202,4 +203,11 @@ void testHashCode() {
         value.setUuid("FDcYsiejIswOtJc");
         assertEquals(-234521635, value.hashCode());
     }
+
+    @Test
+    void createCoordinates() {
+        Queue<Integer> coordinates = MultiselectParameterDefinition.createCoordinates(null, 100, null);
+        assertEquals(1, coordinates.size());
+        assertEquals(100, coordinates.poll());
+    }
 }