Bugfix: Read multiline secrets (#13)

* Read all the lines of the result. In this way, we enable proper reading of multiline secrets.
* Add test for multiline secret case

Author: edif2008

src/main/java/com/onepassword/jenkins/plugins/OnePasswordAccessor.java

@@ -23,6 +23,7 @@
 import java.nio.charset.StandardCharsets;
 import java.util.*;
 import java.util.function.Supplier;
+import java.util.stream.Collectors;
 
 public class OnePasswordAccessor implements Serializable {
 
@@ -126,7 +127,7 @@ public static Map<String, String> retrieveSecrets(Run<?, ?> run, PrintStream log
                 Process pr = pb.command(commands).start();
                 BufferedReader stdInput = new BufferedReader(new InputStreamReader(pr.getInputStream(), StandardCharsets.UTF_8));
                 BufferedReader stdError = new BufferedReader(new InputStreamReader(pr.getErrorStream(), StandardCharsets.UTF_8));
-                String secretValue = stdInput.readLine();
+                String secretValue = stdInput.lines().collect(Collectors.joining(System.lineSeparator()));
                 if (StringUtils.isBlank(secretValue)) {
                     String s;
                     StringBuilder errorMessage = new StringBuilder();

src/test/java/com/onepassword/jenkins/plugins/OnePasswordWithSecretsTest.java

@@ -66,6 +66,20 @@ public void testSecretsPipeline() throws Exception {
         j.assertLogNotContains(TEST_FAILURE, build);
     }
 
+    @Test
+    public void testSecretsMultiline() throws Exception {
+        WorkflowJob project = j.createProject(WorkflowJob.class);
+        project.setDefinition(new CpsFlowDefinition(readFile(basePath + "testSecretsMultiline.groovy",
+                Charset.defaultCharset())
+                .replace("OP_HOST", TEST_CONNECT_HOST)
+                .replace("OP_CLI_URL",OP_CLI_URL),
+                true));
+
+        WorkflowRun build = j.buildAndAssertSuccess(project);
+        j.assertLogContains(TEST_SUCCESS, build);
+        j.assertLogNotContains(TEST_FAILURE, build);
+    }
+
     @Test
     public void testSecretsFromEnv() throws Exception {
         WorkflowJob project = j.createProject(WorkflowJob.class);

src/test/resources/com/onepassword/jenkins/plugins/pipeline/testSecretsMultiline.groovy

@@ -0,0 +1,35 @@
+def config = [
+        connectHost: "OP_HOST",
+        connectCredentialId: "connect-credential-id"
+]
+
+def secrets = [
+        [envVar: 'MULTILINE_SECRET', secretRef: 'op://acceptance-tests/multiline-secret/notesPlain'],
+]
+
+node {
+    sh 'curl -sSfLo op.zip OP_CLI_URL && unzip -o op.zip && rm op.zip'
+    withSecrets(config: config, secrets: secrets) {
+        sh '''
+            if [ "$MULTILINE_SECRET" = "$(cat << EOF
+-----BEGIN PRIVATE KEY-----
+RGVhciBzZWN1cml0eSByZXNlYXJjaGVyLApXaGls
+ZSB3ZSBkZWVwbHkgYXBwcmVjaWF0ZSB5b3VyIHZp
+Z2lsYW5jZSBhbmQgZWZmb3J0cyB0byBtYWtlIHRo
+ZSB3b3JsZCBtb3JlIHNlY3VyZSwgSSdtIGFmcmFp
+ZCBJIG11c3QgdGVsbCB5b3UgdGhhdCB0aGlzIHZh
+bHVlIGlzIG5vdCBhIGFjdHVhbCBwcml2YXRlIGtl
+eS4gCkl0J3MgYSBqdXN0IGEgZHVtbXkgc2VjcmV0
+IHRoYXQgd2UgdXNlIHRvIHRlc3QgdmFyaW91cyAx
+UGFzc3dvcmQgc2VjcmV0cyBpbnRlZ3JhdGlvbnMu
+IApTbyBwbGVhc2UgZG9uJ3QgcmVwb3J0IGl0IQo=
+-----END PRIVATE KEY-----
+EOF
+)" ]; then
+                echo "Strings are equal."
+            else
+                echo "Strings are not equal."
+            fi
+        '''
+    }
+}