Skip to content

Commit b832def

Browse files
authored
Try to clarify something in best practices
Don’t put `stage`s in `parallel` blocks could mean two things: (a) Don't put `stage`s directly in `parallel` blocks (b) Don't put `stage`s in `parallel` blocks even if they're inside `node`s Since (b) would make `parallel` essentially useless, because the view would show a single tickmark when what you'd really want is one tick per parallel result, I'm assuming (a) is what it means. I figured I would pull request it and if it turns out to be the other one, at least we could get it clarified.
1 parent 7d0fc74 commit b832def

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

docs/BEST_PRACTICES.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ This is a collection of tips, advice, gotchas and other best practices for using
1111
* Within `parallel` blocks, use `node` blocks to make sure you farm out to real nodes for your parallelized work.
1212
* Nested `parallel` blocks can lead to swamping your available executors, as each execution of the first `parallel` block calls multiple executions of the second `parallel` block, and so on. In general, think carefully about your parallelism and your available executors when using `parallel`.
1313
* The [Parallel Test Executor plugin](https://github.com/jenkinsci/parallel-test-executor-plugin) is awesome and can be immensely helpful both for distributing your test execution and for throttling your parallelism, since you define how many "buckets" your tests get divided into.
14-
* Don’t put `stage`s in `parallel` blocks - that just goes *weird*, breaking a lot of logic in the Stage View and elsewhere. Save yourself the pain - don't do it!
14+
* Don’t put `stage`s directly inside `parallel` blocks - that just goes *weird*, breaking a lot of logic in the Stage View and elsewhere. Save yourself the pain - don't do it!
1515

1616
# `Jenkinsfile`s and Multibranch
1717
* Use `checkout scm` to automatically checkout current revision of branch

0 commit comments

Comments
 (0)