Skip to content

Commit f07d9ce

Browse files
authored
Merge pull request #562 from ckullabosch/patch-1
[JENKINS-72975] Permit java.util.regex.MatchResult.group(String)
2 parents 1399a91 + 75aeede commit f07d9ce

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

src/main/resources/org/jenkinsci/plugins/scriptsecurity/sandbox/whitelists/generic-whitelist

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -790,11 +790,16 @@ method java.util.random.RandomGenerator nextInt int
790790
method java.util.random.RandomGenerator nextLong
791791
method java.util.regex.MatchResult end
792792
method java.util.regex.MatchResult end int
793+
method java.util.regex.MatchResult end java.lang.String
793794
method java.util.regex.MatchResult group
794795
method java.util.regex.MatchResult group int
796+
method java.util.regex.MatchResult group java.lang.String
795797
method java.util.regex.MatchResult groupCount
798+
method java.util.regex.MatchResult hasMatch
799+
method java.util.regex.MatchResult namedGroups
796800
method java.util.regex.MatchResult start
797801
method java.util.regex.MatchResult start int
802+
method java.util.regex.MatchResult start java.lang.String
798803
method java.util.regex.Matcher appendReplacement java.lang.StringBuffer java.lang.String
799804
method java.util.regex.Matcher appendTail java.lang.StringBuffer
800805
method java.util.regex.Matcher end java.lang.String

src/test/java/org/jenkinsci/plugins/scriptsecurity/sandbox/whitelists/StaticWhitelistTest.java

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141
import java.util.Random;
4242
import java.util.Set;
4343
import java.util.regex.Matcher;
44+
import java.util.regex.MatchResult;
4445

4546
import org.jenkinsci.plugins.scriptsecurity.sandbox.whitelists.EnumeratingWhitelist.MethodSignature;
4647
import org.jenkinsci.plugins.scriptsecurity.sandbox.whitelists.EnumeratingWhitelist.Signature;
@@ -145,7 +146,13 @@ static void sanity(URL definition) throws Exception {
145146
// Override the corresponding MatchResult methods in Java 20+.
146147
new MethodSignature(Matcher.class, "end", String.class),
147148
new MethodSignature(Matcher.class, "group", String.class),
148-
new MethodSignature(Matcher.class, "start", String.class)
149+
new MethodSignature(Matcher.class, "start", String.class),
150+
// Do not exist until Java 20.
151+
new MethodSignature(MatchResult.class, "end", String.class),
152+
new MethodSignature(MatchResult.class, "group", String.class),
153+
new MethodSignature(MatchResult.class, "hasMatch"),
154+
new MethodSignature(MatchResult.class, "namedGroups"),
155+
new MethodSignature(MatchResult.class, "start", String.class)
149156
));
150157

151158
@Test public void sanity() throws Exception {

0 commit comments

Comments
 (0)