Skip to content

Commit 16adabe

Browse files
committed
CpsFlowExecution: rephrase Jenkins Shared Library/JSL (doc book term) to mention Pipeline Groovy library/PGL (plugin term)
@jglick> BTW the terminology in https://www.jenkins.io/doc/book/pipeline/shared-libraries/ is unfortunate. By definition a “library” is “shared”; why else would you create a library? The plugin itself uses the term Pipeline Groovy library. Signed-off-by: Jim Klimov <[email protected]>
1 parent ede9176 commit 16adabe

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

plugin/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -881,11 +881,11 @@ protected static Throwable reportSuspectedMethodTooLarge(Throwable x) {
881881
} else if (overflowedClassName.contains("/")) {
882882
// quote the step/class name pretty:
883883
// FAILED to parse 'stepName' due to...
884-
overflowedClassNameReport = "presumed JSL class '" + overflowedClassName + "'";
884+
overflowedClassNameReport = "presumed PGL (JSL) class '" + overflowedClassName + "'";
885885
} else {
886886
// quote the step/class name pretty:
887887
// FAILED to parse 'stepName' due to...
888-
overflowedClassNameReport = "presumed JSL step '" + overflowedClassName + "'";
888+
overflowedClassNameReport = "presumed PGL (JSL) step '" + overflowedClassName + "'";
889889
}
890890

891891
// Short message suffices, not much that a pipeline developer
@@ -901,15 +901,17 @@ protected static Throwable reportSuspectedMethodTooLarge(Throwable x) {
901901
actionableMsg.append("; please refactor to simplify code structure");
902902
if (overflowedClassNameReport.contains("WorkflowScript")
903903
|| CLASSNAME_SCRIPTNUM_PATTERN.matcher(overflowedClassName).find()) {
904-
actionableMsg.append(" and/or move logic to a Jenkins Shared Library");
904+
actionableMsg.append(" and/or move logic to a Pipeline Groovy library" +
905+
"(aka Jenkins Shared Library in some documentation)");
905906
}
906907
if (xMsgStart.length() > 0) {
907908
actionableMsg.append(":\n-----\n").append(xMsgStart.toString());
908909
}
909910
if (overflowedClassNameBreadcrumbs.length() > 0) {
910911
actionableMsg
911912
.append(
912-
"\nGroovy code trail (mentions of pipeline WorkflowScript and/or your JSL in larger stack trace):\n")
913+
"\nGroovy code trail (mentions of pipeline WorkflowScript " +
914+
"and/or your PGL (JSL) in larger stack trace):\n")
913915
.append(overflowedClassNameBreadcrumbs);
914916
}
915917
if (xMsgStart.length() > 0) {

0 commit comments

Comments
 (0)