CpsFlowExecution.parseScript(): MethodTooLargeException: actionable suggestions for pipeline devs

jimklimov · jimklimov · commit 66afa75051a3 · 2024-03-05T15:16:49.000+01:00
Signed-off-by: Jim Klimov &lt;jimklimov+jenkinsci@gmail.com&gt;
diff --git a/plugin/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java b/plugin/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java
@@ -685,7 +685,8 @@ private CpsScript parseScript() throws IOException {
             }
             // Short message suffices, not much that a pipeline developer
             // can do with the stack trace into the guts of groovy
-            msg += ": " + mtlEx.getMessage();
+            msg += "; please refactor to simplify code structure and/or move logic to a Jenkins Shared Library: ";
+            msg += mtlEx.getMessage();
 
             // Make a note in server log
             LOGGER.log(Level.SEVERE, msg);

Original file line number	Diff line number	Diff line change
`@@ -685,7 +685,8 @@ private CpsScript parseScript() throws IOException {`
`685`	`685`	`}`
`686`	`686`	`// Short message suffices, not much that a pipeline developer`
`687`	`687`	`// can do with the stack trace into the guts of groovy`
`688`		`- msg += ": " + mtlEx.getMessage();`
	`688`	`+ msg += "; please refactor to simplify code structure and/or move logic to a Jenkins Shared Library: ";`
	`689`	`+ msg += mtlEx.getMessage();`
`689`	`690`
`690`	`691`	`// Make a note in server log`
`691`	`692`	`LOGGER.log(Level.SEVERE, msg);`