CpsFlowExecution: restore the multi-catch for "RuntimeException | Error"

Notably, the latter is a Throwable but not an Exception so e.g. LinkageError might be not handled.

Signed-off-by: Jim Klimov <[email protected]>

Author: jimklimov

plugin/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java

@@ -639,15 +639,17 @@ private CpsScript parseScript() throws IOException {
             for (Entry<String, String> e : loadedScripts.entrySet()) {
                 shell.reparse(e.getKey(), e.getValue());
             }
-        } catch (Exception x) {
+        } catch (RuntimeException | Error x) {
             // Suspected groovyjarjarasm.asm.MethodTooLargeException or a
             // org.codehaus.groovy.control.MultipleCompilationErrorsException
             // whose collection of errors refers to MethodTooLargeException.
             // Per review comments, we do not want to statically compile a
             // dependency on the groovyjarjarasm.asm.MethodTooLargeException
             // internals, so gauge hitting it via String name comparisons.
             // Other cases may be (subclasses of) RuntimeException or Error.
-            Exception mtlEx = null;
+            // Note that both MultipleCompilationErrorsException and
+            // MethodTooLargeException are descended from RuntimeException.
+            Throwable mtlEx = null;
             int ecCount = 0;
 
             // Clean up first