Merge pull request #298 from bitwiseman/patch-3

Add Java 11 build

Author: dwnusbaum

Jenkinsfile

@@ -1 +1 @@
-buildPlugin()
+buildPlugin(configurations: buildPlugin.recommendedConfigurations())

src/main/java/org/jenkinsci/plugins/workflow/cps/CpsFlowExecution.java

@@ -179,7 +179,7 @@
  * </dd>
  * <dt>PERSISTED</dt>
  * <dd>
- *     {@link CpsFlowExecution} is on disk with its owner, for example in <tt>build.xml</tt> of the workflow run.
+ *     {@link CpsFlowExecution} is on disk with its owner, for example in {@code build.xml} of the workflow run.
  *     Nothing exists in memory. For example, Jenkins is not running.
  *
  *     Transition from this into PREPARING is triggered outside our control by XStream using

src/main/java/org/jenkinsci/plugins/workflow/cps/CpsScmFlowDefinition.java

@@ -24,6 +24,7 @@
 
 package org.jenkinsci.plugins.workflow.cps;
 
+import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import hudson.AbortException;
 import hudson.Extension;
 import hudson.FilePath;
@@ -35,7 +36,6 @@
 import hudson.model.Node;
 import hudson.model.Queue;
 import hudson.model.Run;
-import hudson.model.Run.RunnerAbortedException;
 import hudson.model.TaskListener;
 import hudson.model.TopLevelItem;
 import hudson.scm.SCM;
@@ -92,6 +92,11 @@ public boolean isLightweight() {
         this.lightweight = lightweight;
     }
 
+    @SuppressFBWarnings(
+            value = {"NP_LOAD_OF_KNOWN_NULL_VALUE", "RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE",
+                    "RCN_REDUNDANT_NULLCHECK_OF_NULL_VALUE", "RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE"},
+            justification = "false positives for try-resource in java 11"
+    )
     @Override public CpsFlowExecution create(FlowExecutionOwner owner, TaskListener listener, List<? extends Action> actions) throws Exception {
         for (Action a : actions) {
             if (a instanceof CpsFlowFactoryAction2) {