Skip to content

Commit e2e99a4

Browse files
authored
Merge pull request #689 from jglick/multimodule-simplified
Support PCT for multi-module Maven projects (II)
2 parents def0e33 + 7fc2223 commit e2e99a4

File tree

2 files changed

+17
-26
lines changed

2 files changed

+17
-26
lines changed

dgm-builder/pom.xml

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
</licenses>
2323

2424
<properties>
25+
<maven.install.skip>true</maven.install.skip>
2526
<maven.deploy.skip>true</maven.deploy.skip>
2627
</properties>
2728

@@ -32,7 +33,7 @@
3233
<artifactId>maven-assembly-plugin</artifactId>
3334
<executions>
3435
<execution>
35-
<phase>package</phase>
36+
<phase>process-classes</phase>
3637
<goals>
3738
<goal>single</goal>
3839
</goals>
@@ -74,19 +75,4 @@
7475
<version>${groovy.version}</version>
7576
</dependency>
7677
</dependencies>
77-
78-
<profiles>
79-
<profile>
80-
<id>skip-installation</id>
81-
<activation>
82-
<property>
83-
<name>set.changelist</name>
84-
<value>true</value>
85-
</property>
86-
</activation>
87-
<properties>
88-
<maven.install.skip>true</maven.install.skip>
89-
</properties>
90-
</profile>
91-
</profiles>
9278
</project>

lib/pom.xml

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -29,8 +29,21 @@
2929
<executions>
3030
<execution>
3131
<goals>
32-
<goal>properties</goal>
32+
<goal>copy</goal>
3333
</goals>
34+
<phase>generate-sources</phase>
35+
<configuration>
36+
<artifactItems>
37+
<artifactItem>
38+
<groupId>com.cloudbees</groupId>
39+
<artifactId>groovy-cps-dgm-builder</artifactId>
40+
<version>${project.version}</version>
41+
<classifier>jar-with-dependencies</classifier>
42+
</artifactItem>
43+
</artifactItems>
44+
<outputDirectory>${project.build.directory}</outputDirectory>
45+
<overWriteIfNewer>true</overWriteIfNewer>
46+
</configuration>
3447
</execution>
3548
</executions>
3649
</plugin>
@@ -49,7 +62,7 @@
4962
<executable>java</executable>
5063
<arguments>
5164
<argument>-jar</argument>
52-
<argument>${com.cloudbees:groovy-cps-dgm-builder:jar:jar-with-dependencies}</argument>
65+
<argument>${project.build.directory}/groovy-cps-dgm-builder-${project.version}-jar-with-dependencies.jar</argument>
5366
<argument>${project.build.directory}/generated-sources/dgm</argument>
5467
</arguments>
5568
</configuration>
@@ -64,14 +77,6 @@
6477
<no-test-jar>false</no-test-jar>
6578
</properties>
6679
<dependencies>
67-
<dependency>
68-
<groupId>com.cloudbees</groupId>
69-
<artifactId>groovy-cps-dgm-builder</artifactId>
70-
<version>${changelist}</version>
71-
<classifier>jar-with-dependencies</classifier>
72-
<scope>runtime</scope> <!-- somehow provide to dependency:properties without actually adding to CP -->
73-
<optional>true</optional>
74-
</dependency>
7580
<dependency>
7681
<groupId>com.github.spotbugs</groupId>
7782
<artifactId>spotbugs-annotations</artifactId>

0 commit comments

Comments
 (0)