Skip to content

Commit 7ef2531

Browse files
committed
Update appraisals/gemfiles, add contributing notes
1 parent 3e82999 commit 7ef2531

File tree

6 files changed

+43
-38
lines changed

6 files changed

+43
-38
lines changed

Appraisals

Lines changed: 12 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,39 +1,28 @@
1-
appraise "activerecord-3.2" do
2-
gem "activerecord", "~> 3.2.0"
3-
gem "mysql", "~> 2.8"
4-
gem "mysql2", "~> 0.3.10"
5-
gem 'pg', '~> 0.11'
6-
gem "sqlite3", "~> 1.3.5"
7-
end
8-
9-
appraise "activerecord-4.0" do
10-
gem "activerecord", "~> 4.0.0"
11-
gem "mysql", "~> 2.8"
12-
gem "mysql2", "~> 0.3.10"
13-
gem 'pg', '~> 0.11'
1+
appraise "activerecord-5.0" do
2+
gem "activerecord", "~> 5.0.0"
3+
gem "mysql2", "~> 0.4.10"
4+
gem "pg", ">= 0.18", "< 2.0"
145
gem "sqlite3", "~> 1.3.6"
15-
166
end
177

18-
appraise "activerecord-4.2" do
19-
gem "activerecord", "~> 4.2.0"
20-
gem 'mysql', '~> 2.9'
21-
gem 'mysql2', '>= 0.3.13', '< 0.5'
22-
gem 'pg', '~> 0.15'
8+
appraise "activerecord-5.1" do
9+
gem "activerecord", "~> 5.1.0"
10+
gem "mysql2", "~> 0.4.10"
11+
gem "pg", ">= 0.18", "< 2.0"
2312
gem "sqlite3", "~> 1.3.6"
2413
end
2514

26-
appraise "activerecord-5.0" do
27-
gem "activerecord", "~> 5.0.0"
28-
gem "mysql2", "~> 0.4.4"
15+
appraise "activerecord-5.2" do
16+
gem "activerecord", "~> 5.2.0"
17+
gem "mysql2", "~> 0.4.10"
2918
gem "pg", ">= 0.18", "< 2.0"
3019
gem "sqlite3", "~> 1.3.6"
3120
end
3221

3322
appraise "activerecord-edge" do
3423
gem "arel", github: "rails/arel"
3524
gem "activerecord", github: "rails/rails"
36-
gem "mysql2", "~> 0.3.11"
25+
gem "mysql2", "~> 0.4.10"
3726
gem "pg", ">= 0.18", "< 2.0"
3827
gem "sqlite3", "~> 1.3.6"
3928
end

README.md

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -320,6 +320,22 @@ existing trigger if you wish to redefine it.
320320
* Manual `create_trigger` statements have some gotchas. See the section
321321
"Manual triggers and :compatibility"
322322

323+
## Contributing
324+
325+
Contributions welcome! I don't write much Ruby these days 😢 (and haven't used this
326+
gem in years 😬) but am happy to take contributions. If I'm slow to respond, don't
327+
hesitate to @ me repeatedly, sometimes those github notifications slip through
328+
the cracks. 😆.
329+
330+
If you want to add a feature/bugfix, you can rely on Travis to run the tests, but
331+
do also run them locally (especially if you are changing supported railses/etc).
332+
HairTrigger uses [appraisal](https://github.com/thoughtbot/appraisal) to manage all
333+
that w/ automagical gemfiles. So the tl;dr when testing locally is:
334+
335+
1. make sure you have mysql and postgres installed (homebrew or whatever)
336+
2. `bundle exec appraisal install` -- get all the dependencies
337+
3. `bundle exec appraisal rake` -- run the specs every which way
338+
323339
## Compatibility
324340

325341
* Ruby 2.3.0+
@@ -332,4 +348,4 @@ existing trigger if you wish to redefine it.
332348

333349
## Copyright
334350

335-
Copyright (c) 2011-2018 Jon Jensen. See LICENSE.txt for further details.
351+
Copyright (c) 2011-2019 Jon Jensen. See LICENSE.txt for further details.

gemfiles/activerecord_5.0.gemfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
source "https://rubygems.org"
44

55
gem "activerecord", "~> 5.0.0"
6-
gem "mysql2", "~> 0.4.4"
6+
gem "mysql2", "~> 0.4.10"
77
gem "pg", ">= 0.18", "< 2.0"
88
gem "sqlite3", "~> 1.3.6"
99

@@ -17,4 +17,4 @@ group :test do
1717
gem "rspec", "~> 2.14.0"
1818
end
1919

20-
gemspec path: "../"
20+
gemspec :path => "../"

gemfiles/activerecord_5.1.gemfile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@
33
source "https://rubygems.org"
44

55
gem "activerecord", "~> 5.1.0"
6-
gem "mysql2", "~> 0.4.4"
6+
gem "mysql2", "~> 0.4.10"
7+
gem "pg", ">= 0.18", "< 2.0"
8+
gem "sqlite3", "~> 1.3.6"
79

810
group :development do
911
gem "appraisal"
@@ -13,8 +15,6 @@ end
1315
group :test do
1416
gem "rake", "~> 10.0"
1517
gem "rspec", "~> 2.14.0"
16-
gem "pg", ">= 0.18", "< 2.0"
17-
gem "sqlite3", "~> 1.3.6"
1818
end
1919

20-
gemspec path: "../"
20+
gemspec :path => "../"

gemfiles/activerecord_5.2.gemfile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@
33
source "https://rubygems.org"
44

55
gem "activerecord", "~> 5.2.0"
6-
gem "mysql2", "~> 0.4.4"
6+
gem "mysql2", "~> 0.4.10"
7+
gem "pg", ">= 0.18", "< 2.0"
8+
gem "sqlite3", "~> 1.3.6"
79

810
group :development do
911
gem "appraisal"
@@ -13,8 +15,6 @@ end
1315
group :test do
1416
gem "rake", "~> 10.0"
1517
gem "rspec", "~> 2.14.0"
16-
gem "pg", ">= 0.18", "< 2.0"
17-
gem "sqlite3", "~> 1.3.6"
1818
end
1919

20-
gemspec path: "../"
20+
gemspec :path => "../"

gemfiles/activerecord_edge.gemfile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22

33
source "https://rubygems.org"
44

5-
gem "arel", github: "rails/arel"
6-
gem "activerecord", github: "rails/rails"
7-
gem "mysql2", "~> 0.3.11"
5+
gem "arel", :github => "rails/arel"
6+
gem "activerecord", :github => "rails/rails"
7+
gem "mysql2", "~> 0.4.10"
88
gem "pg", ">= 0.18", "< 2.0"
99
gem "sqlite3", "~> 1.3.6"
1010

@@ -18,4 +18,4 @@ group :test do
1818
gem "rspec", "~> 2.14.0"
1919
end
2020

21-
gemspec path: "../"
21+
gemspec :path => "../"

0 commit comments

Comments
 (0)