fix: update seller information to new format (#152)

Author: GideonBear

src/marktplaats/api_types.py

@@ -253,3 +253,9 @@ class MetaTags(TypedDict):
     metaTitle: str
     metaDescription: str
     pageTitleH1: str
+
+
+class Review(TypedDict):
+    numberOfReviews: int
+    averageScore: int
+    reviewSystem: str

src/marktplaats/models/listing_seller.py

@@ -10,16 +10,16 @@
 
 
 if TYPE_CHECKING:
-    from marktplaats.api_types import SellerInformation
+    from marktplaats.api_types import Review, SellerInformation
 
 
 @dataclass
 class Seller:
     id: int
     name: str
     is_verified: bool
-    average_score: float
-    number_of_reviews: int
+    average_score: float | None
+    number_of_reviews: int | None
     bank_account: bool
     identification: bool
     phone_number: bool
@@ -47,12 +47,15 @@ def get_seller(self) -> Seller:
         body = request.text
         body_json = json.loads(body)
 
+        review: Review | None = (
+            body_json["reviews"][0] if body_json["reviews"] else None
+        )
         return Seller(
             self.id,
             self.name,
             self.is_verified,
-            body_json["averageScore"],
-            body_json["numberOfReviews"],
+            review["averageScore"] if review else None,
+            review["numberOfReviews"] if review else None,
             body_json["bankAccount"],
             body_json["identification"],
             body_json["phoneNumber"],

tests/mock/seller_response.json

@@ -5,8 +5,14 @@
     "paymentMethod": {
         "name": "ideal"
     },
-    "numberOfReviews": 26,
-    "averageScore": 5,
     "smbVerified": false,
-    "profilePictures": {}
+    "profilePictures": {},
+    "salesRepresentatives": [],
+    "reviews": [
+        {
+            "numberOfReviews": 175,
+            "averageScore": 4.8,
+            "reviewSystem": "INTERNAL_REVIEWS"
+        }
+    ]
 }

tests/test_live.py

@@ -61,8 +61,9 @@ def _validate_response(search: SearchQuery, check_time: bool = False) -> None:
         assert isinstance(seller.id, int)
         assert isinstance(seller.name, str)
         assert isinstance(seller.is_verified, bool)
-        assert seller.average_score is not None
-        assert isinstance(seller.number_of_reviews, int)
+        if seller.average_score is not None:
+            assert isinstance(seller.average_score, (float, int))
+            assert isinstance(seller.number_of_reviews, int)
         assert isinstance(seller.bank_account, bool)
         assert isinstance(seller.identification, bool)
         assert isinstance(seller.phone_number, bool)

tests/test_query.py

@@ -133,7 +133,8 @@ def test_request_1() -> None:
 
     assert not seller.is_verified  # should still be false
     assert seller.id == 7405065  # should still be the same
-    assert seller.average_score == 5
+    assert seller.average_score == 4.8  # noqa: RUF069
+    assert seller.number_of_reviews == 175
     assert seller.bank_account
     assert not seller.identification
     assert seller.phone_number