Skip to content

Commit 26f765d

Browse files
committed
cpuset controller required for cgroups v1
1 parent bfa9032 commit 26f765d

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

src/hotspot/os/linux/cgroupSubsystem_linux.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,6 @@ bool CgroupSubsystemFactory::determine_type(CgroupInfo* cg_infos,
335335
cg_infos[MEMORY_IDX]._hierarchy_id = hierarchy_id;
336336
cg_infos[MEMORY_IDX]._enabled = (enabled == 1);
337337
} else if (strcmp(name, "cpuset") == 0) {
338-
log_debug(os, container)("Detected optional cpuset controller entry in %s", controllers_file);
339338
cg_infos[CPUSET_IDX]._name = os::strdup(name);
340339
cg_infos[CPUSET_IDX]._hierarchy_id = hierarchy_id;
341340
cg_infos[CPUSET_IDX]._enabled = (enabled == 1);
@@ -355,8 +354,8 @@ bool CgroupSubsystemFactory::determine_type(CgroupInfo* cg_infos,
355354
}
356355
}
357356
for (int i = 0; i < CG_INFO_LENGTH; i++) {
358-
// pids and cpuset controllers are optional. All other controllers are required
359-
if (i != PIDS_IDX && i != CPUSET_IDX) {
357+
// pid controller is optional. All other controllers are required
358+
if (i != PIDS_IDX) {
360359
all_required_controllers_enabled = all_required_controllers_enabled && cg_infos[i]._enabled;
361360
}
362361
if (log_is_enabled(Debug, os, container) && !cg_infos[i]._enabled) {

test/hotspot/jtreg/containers/cgroup/CgroupSubsystemFactory.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -551,7 +551,7 @@ public void testCgroupv1CpusetMissingFromProcCgroups(WhiteBox wb) {
551551
String procSelfCgroup = cgroupV1SelfCgroupNoCpuset.toString();
552552
String procSelfMountinfo = cgroupv1MntInfoNonZeroHierarchyNoCpuset.toString();
553553
int retval = wb.validateCgroup(false, procCgroups, procSelfCgroup, procSelfMountinfo);
554-
Asserts.assertEQ(INVALID_CGROUPS_V1, retval, "Required cpuset controller missing in /proc/cgroups. Invalid.");
554+
Asserts.assertEQ(INVALID_CGROUPS_GENERIC, retval, "Required cpuset controller missing in /proc/cgroups. Invalid.");
555555
Asserts.assertFalse(isValidCgroup(retval));
556556
System.out.println("testCgroupv1CpusetMissingFromProcCgroups PASSED!");
557557
}

0 commit comments

Comments
 (0)