Skip to content

Commit 580b4b1

Browse files
committed
Review feedback from Alan
1 parent 2f48c81 commit 580b4b1

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

src/jdk.jlink/share/classes/jdk/tools/jlink/internal/plugins/ReleaseInfoPlugin.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,13 @@
2525
package jdk.tools.jlink.internal.plugins;
2626

2727
import java.io.ByteArrayOutputStream;
28-
import java.io.FileInputStream;
29-
import java.io.InputStreamReader;
3028
import java.io.IOException;
3129
import java.io.PrintWriter;
30+
import java.io.Reader;
3231
import java.io.UncheckedIOException;
3332
import java.lang.module.ModuleDescriptor;
33+
import java.nio.file.Files;
34+
import java.nio.file.Path;
3435
import java.util.EnumSet;
3536
import java.util.HashMap;
3637
import java.util.Map;
@@ -108,8 +109,8 @@ public void configure(Map<String, String> config) {
108109
default: {
109110
// --release-info <file>
110111
Properties props = new Properties();
111-
try (InputStreamReader isr = new InputStreamReader(new FileInputStream(operation), "UTF-8")) {
112-
props.load(isr);
112+
try (Reader reader = Files.newBufferedReader(Path.of(operation))) {
113+
props.load(reader); // Use reader API so as to read in as UTF-8
113114
} catch (IOException exp) {
114115
throw new UncheckedIOException(exp);
115116
}

test/jdk/tools/jlink/plugins/ReleaseInfoPluginTest.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,7 @@
2424
import jdk.test.lib.process.*;
2525
import jdk.test.lib.Asserts;
2626

27-
import java.io.InputStreamReader;
28-
import java.io.FileInputStream;
27+
import java.io.Reader;
2928
import java.nio.charset.StandardCharsets;
3029
import java.nio.file.Path;
3130
import java.nio.file.Files;
@@ -67,12 +66,12 @@ public static void main(String[] args) throws Throwable {
6766
"--release-info", utf8File.toString()
6867
}, "java.base").assertSuccess();
6968

70-
// release file produced should have IMPLEMENTOR in an
71-
// appropriate encoding
69+
// release file produced should have IMPLEMENTOR in
70+
// UTF-8 encoding
7271
var release = image.resolve("release");
7372
Properties props = new Properties();
74-
try (InputStreamReader isr = new InputStreamReader(new FileInputStream(release.toFile()), "UTF-8")) {
75-
props.load(isr);
73+
try (Reader reader= Files.newBufferedReader(release)) {
74+
props.load(reader); // Load as UTF-8
7675
}
7776
String noQuotesMods = ((String)props.get("MODULES")).replace("\"", "");
7877
Asserts.assertEquals("java.base", noQuotesMods);

0 commit comments

Comments
 (0)