fix(s3-service/getObject): resolve wrong output type received (#236)

- before this change, we received [object Object] because the AWS SDK returned us a stream instead of a buffer like it used to be in v2, and it was dealt with like a buffer

Author: naorpeled

lib/s3-service.js

@@ -8,15 +8,23 @@
 // Require AWS SDK
 const { S3Client, GetObjectCommand } = require('@aws-sdk/client-s3'); // AWS SDK
 const { getSignedUrl } = require('@aws-sdk/s3-request-presigner');
+const { streamToBuffer } = require('./utils');
 
 // Export
 exports.client = new S3Client();
 
 exports.getObject = (params) => {
-  const cmd = new GetObjectCommand(params);
-  const promise = this.client.send(cmd);
   return {
-    promise: () => promise,
+    promise: async () => {
+      const res = await this.client.send(new GetObjectCommand(params));
+
+      if (!res.Body) return res;
+
+      return {
+        ...res,
+        Body: await streamToBuffer(res.Body),
+      };
+    },
   };
 };
 

lib/utils.js

@@ -201,3 +201,11 @@ exports.stringifyHeaders = (headers) =>
       }),
     {}
   );
+
+exports.streamToBuffer = (stream) =>
+  new Promise((resolve, reject) => {
+    const chunks = [];
+    stream.on('data', (chunk) => chunks.push(chunk));
+    stream.on('error', reject);
+    stream.on('end', () => resolve(Buffer.concat(chunks)));
+  });