ci: add previous MySQL versions to integration tests matrix

Author: naorpeled

.github/workflows/integration-tests.yml

@@ -16,12 +16,13 @@ jobs:
     strategy:
       matrix:
         node: [18, 20, 22]
-    name: Node ${{ matrix.node }} Integration Tests
+        mysql: ["5", "lts"]
+    name: Node ${{ matrix.node }} with MySQL ${{ matrix.mysql }} Integration Tests
     timeout-minutes: 5
 
     services:
       mysql:
-        image: mysql:8.0.33
+        image: mysql:${{ matrix.mysql }}
         env:
           MYSQL_ROOT_PASSWORD: password
           MYSQL_DATABASE: serverless_mysql_test
@@ -61,7 +62,7 @@ jobs:
           MYSQL_PASSWORD: password
 
       - name: Run all tests with coverage
-        if: matrix.node == 22
+        if: matrix.node == 22 && matrix.mysql == 'lts'
         run: npm run test-cov
         env:
           MYSQL_HOST: 127.0.0.1

CONTRIBUTING.md

@@ -123,20 +123,35 @@ This will generate an HTML coverage report in the `coverage` directory.
 
 ## Integration Test Environment
 
-The integration tests use a MySQL 8.0 container with the following configuration:
+The integration tests support multiple MySQL versions in the CI environment to ensure compatibility across different database environments. The GitHub Actions workflow is configured to test against:
+
+- MySQL 5 (latest in the 5.x series)
+- MySQL LTS (Long Term Support version)
+
+For local development, the `docker-compose.yml` file includes a single MySQL service using the `mysql:lts` image to ensure we always test against the most recent Long Term Support version. The connection details are:
 
 - Host: 127.0.0.1
 - Port: 3306
 - Database: serverless_mysql_test
 - User: root
 - Password: password
 
+```bash
+# Start MySQL container
+docker compose up -d
+
+# Run integration tests
+npm run test:integration
+
+# Stop MySQL container when done
+docker compose down
+```
+
 The MySQL container is configured with:
-- Native password authentication
 - 1000 max connections
 - Extended wait timeout (28800 seconds)
 
-This is configured in the `docker-compose.yml` file and used by the GitHub Actions workflow for CI.
+The GitHub Actions workflow runs integration tests against both MySQL versions to ensure compatibility.
 
 ## Continuous Integration
 

docker-compose.yml

@@ -1,6 +1,6 @@
 services:
   mysql:
-    image: mysql:8.0
+    image: mysql:lts
     container_name: serverless-mysql-test-db
     environment:
       MYSQL_ROOT_PASSWORD: password
@@ -13,7 +13,6 @@ services:
     ports:
       - "3306:3306"
     command: >
-      --default-authentication-plugin=mysql_native_password
       --max_connections=1000
       --wait_timeout=28800
     healthcheck:

test/integration/change-user.spec.js

@@ -77,16 +77,30 @@ describe('MySQL changeUser Integration Tests', function () {
 
     it('should handle errors when changing to non-existent user', async function () {
         try {
+            const nonExistentUser = 'non_existent_user_' + Date.now();
             await db.changeUser({
-                user: 'non_existent_user_' + Date.now(),
+                user: nonExistentUser,
                 password: 'wrong_password'
             });
 
             expect.fail('Should have thrown an error');
         } catch (error) {
             expect(error).to.be.an('error');
-            expect(error).to.have.property('code');
-            expect(error.message).to.include('Access denied for user', 'Error message should indicate access was denied');
+
+            // In MySQL 8.4+ (LTS), the mysql_native_password plugin is not loaded by default
+            // In older MySQL versions, we get an access denied error
+            expect(error.code).to.be.oneOf([
+                'ER_ACCESS_DENIED_ERROR',  // Older MySQL versions
+                'ER_PLUGIN_IS_NOT_LOADED'  // MySQL 8.4+ (LTS)
+            ]);
+
+            if (error.code === 'ER_PLUGIN_IS_NOT_LOADED') {
+                expect(error.message).to.include('Plugin');
+                expect(error.message).to.include('mysql_native_password');
+                expect(error.message).to.include('not loaded');
+            } else {
+                expect(error.message).to.include('Access denied for user');
+            }
         }
     });