Skip to content

Commit 1753970

Browse files
committed
OTEL_PYTHON_LOG_LEVEL
1 parent c5dcf46 commit 1753970

File tree

3 files changed

+17
-31
lines changed

3 files changed

+17
-31
lines changed

opentelemetry-sdk/src/opentelemetry/sdk/_configuration/__init__.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
OTEL_EXPORTER_OTLP_PROTOCOL,
4747
OTEL_EXPORTER_OTLP_TRACES_PROTOCOL,
4848
OTEL_PYTHON_LOG_FORMAT,
49-
OTEL_PYTHON_LOG_HANDLER_LEVEL,
49+
OTEL_PYTHON_LOG_LEVEL,
5050
OTEL_TRACES_SAMPLER,
5151
OTEL_TRACES_SAMPLER_ARG,
5252
)
@@ -91,7 +91,7 @@
9191

9292
_OTEL_SAMPLER_ENTRY_POINT_GROUP = "opentelemetry_traces_sampler"
9393

94-
_OTEL_PYTHON_LOG_HANDLER_LEVEL_BY_NAME = {
94+
_OTEL_PYTHON_LOG_LEVEL_BY_NAME = {
9595
"notset": logging.NOTSET,
9696
"debug": logging.DEBUG,
9797
"info": logging.INFO,
@@ -145,8 +145,8 @@ def _get_id_generator() -> str:
145145

146146

147147
def _get_log_level() -> int:
148-
return _OTEL_PYTHON_LOG_HANDLER_LEVEL_BY_NAME.get(
149-
environ.get(OTEL_PYTHON_LOG_HANDLER_LEVEL, "notset").lower().strip(),
148+
return _OTEL_PYTHON_LOG_LEVEL_BY_NAME.get(
149+
environ.get(OTEL_PYTHON_LOG_LEVEL, "notset").lower().strip(),
150150
logging.NOTSET,
151151
)
152152

@@ -277,7 +277,7 @@ def _init_logging(
277277
root_logger = logging.getLogger()
278278
handler = LoggingHandler(logger_provider=provider)
279279
# Log level
280-
if OTEL_PYTHON_LOG_HANDLER_LEVEL in environ:
280+
if OTEL_PYTHON_LOG_LEVEL in environ:
281281
handler.setLevel(_get_log_level())
282282
# Log format
283283
if OTEL_PYTHON_LOG_FORMAT in environ:

opentelemetry-sdk/src/opentelemetry/sdk/environment_variables/__init__.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,11 +62,11 @@
6262
Default: "logging.BASIC_FORMAT"
6363
"""
6464

65-
OTEL_PYTHON_LOG_HANDLER_LEVEL = "OTEL_PYTHON_LOG_HANDLER_LEVEL"
65+
OTEL_PYTHON_LOG_LEVEL = "OTEL_PYTHON_LOG_LEVEL"
6666
"""
67-
.. envvar:: OTEL_PYTHON_LOG_HANDLER_LEVEL
67+
.. envvar:: OTEL_PYTHON_LOG_LEVEL
6868
69-
The :envvar:`OTEL_PYTHON_LOG_HANDLER_LEVEL` environment variable sets the log level for the OpenTelemetry LoggingHandler
69+
The :envvar:`OTEL_PYTHON_LOG_LEVEL` environment variable sets the log level for the OpenTelemetry LoggingHandler
7070
Default: "logging.NOTSET"
7171
"""
7272

opentelemetry-sdk/tests/test_configurator.py

Lines changed: 9 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -713,7 +713,7 @@ def test_logging_init_exporter_without_handler_setup(self):
713713
environ,
714714
{
715715
"OTEL_RESOURCE_ATTRIBUTES": "service.name=otlp-service",
716-
"OTEL_PYTHON_LOG_HANDLER_LEVEL": "CUSTOM_LOG_LEVEL",
716+
"OTEL_PYTHON_LOG_LEVEL": "CUSTOM_LOG_LEVEL",
717717
},
718718
clear=True,
719719
)
@@ -750,7 +750,7 @@ def test_logging_init_exporter_level_under(self, log_level_mock):
750750
environ,
751751
{
752752
"OTEL_RESOURCE_ATTRIBUTES": "service.name=otlp-service",
753-
"OTEL_PYTHON_LOG_HANDLER_LEVEL": "CUSTOM_LOG_LEVEL",
753+
"OTEL_PYTHON_LOG_LEVEL": "CUSTOM_LOG_LEVEL",
754754
},
755755
clear=True,
756756
)
@@ -822,45 +822,31 @@ def test_logging_init_exporter_format(self):
822822
def test_otel_log_level_by_name_default(self):
823823
self.assertEqual(_get_log_level(), NOTSET)
824824

825-
@patch.dict(
826-
environ, {"OTEL_PYTHON_LOG_HANDLER_LEVEL": "NOTSET "}, clear=True
827-
)
825+
@patch.dict(environ, {"OTEL_PYTHON_LOG_LEVEL": "NOTSET "}, clear=True)
828826
def test_otel_log_level_by_name_notset(self):
829827
self.assertEqual(_get_log_level(), NOTSET)
830828

831-
@patch.dict(
832-
environ, {"OTEL_PYTHON_LOG_HANDLER_LEVEL": " DeBug "}, clear=True
833-
)
829+
@patch.dict(environ, {"OTEL_PYTHON_LOG_LEVEL": " DeBug "}, clear=True)
834830
def test_otel_log_level_by_name_debug(self):
835831
self.assertEqual(_get_log_level(), DEBUG)
836832

837-
@patch.dict(
838-
environ, {"OTEL_PYTHON_LOG_HANDLER_LEVEL": " info "}, clear=True
839-
)
833+
@patch.dict(environ, {"OTEL_PYTHON_LOG_LEVEL": " info "}, clear=True)
840834
def test_otel_log_level_by_name_info(self):
841835
self.assertEqual(_get_log_level(), INFO)
842836

843-
@patch.dict(
844-
environ, {"OTEL_PYTHON_LOG_HANDLER_LEVEL": " warn"}, clear=True
845-
)
837+
@patch.dict(environ, {"OTEL_PYTHON_LOG_LEVEL": " warn"}, clear=True)
846838
def test_otel_log_level_by_name_warn(self):
847839
self.assertEqual(_get_log_level(), WARNING)
848840

849-
@patch.dict(
850-
environ, {"OTEL_PYTHON_LOG_HANDLER_LEVEL": " warnING "}, clear=True
851-
)
841+
@patch.dict(environ, {"OTEL_PYTHON_LOG_LEVEL": " warnING "}, clear=True)
852842
def test_otel_log_level_by_name_warning(self):
853843
self.assertEqual(_get_log_level(), WARNING)
854844

855-
@patch.dict(
856-
environ, {"OTEL_PYTHON_LOG_HANDLER_LEVEL": " eRroR"}, clear=True
857-
)
845+
@patch.dict(environ, {"OTEL_PYTHON_LOG_LEVEL": " eRroR"}, clear=True)
858846
def test_otel_log_level_by_name_error(self):
859847
self.assertEqual(_get_log_level(), ERROR)
860848

861-
@patch.dict(
862-
environ, {"OTEL_PYTHON_LOG_HANDLER_LEVEL": "foobar"}, clear=True
863-
)
849+
@patch.dict(environ, {"OTEL_PYTHON_LOG_LEVEL": "foobar"}, clear=True)
864850
def test_otel_log_level_by_name_invalid(self):
865851
self.assertEqual(_get_log_level(), NOTSET)
866852

0 commit comments

Comments
 (0)