Skip to content

Commit 910e4d4

Browse files
committed
Use OTEL_PYTHON_LOG_LEVEL instead
1 parent b7aebd1 commit 910e4d4

File tree

2 files changed

+21
-21
lines changed

2 files changed

+21
-21
lines changed

opentelemetry-sdk/src/opentelemetry/sdk/_configuration/__init__.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747
OTEL_EXPORTER_OTLP_TRACES_PROTOCOL,
4848
OTEL_TRACES_SAMPLER,
4949
OTEL_TRACES_SAMPLER_ARG,
50-
OTEL_LOG_LEVEL,
50+
OTEL_PYTHON_LOG_LEVEL,
5151
OTEL_PYTHON_LOG_FORMAT,
5252
)
5353
from opentelemetry.sdk.metrics import MeterProvider
@@ -91,7 +91,7 @@
9191

9292
_OTEL_SAMPLER_ENTRY_POINT_GROUP = "opentelemetry_traces_sampler"
9393

94-
_OTEL_LOG_LEVEL_BY_NAME = {
94+
_OTEL_PYTHON_LOG_LEVEL_BY_NAME = {
9595
"notset": logging.NOTSET,
9696
"debug": logging.DEBUG,
9797
"info": logging.INFO,
@@ -144,7 +144,7 @@ def _get_id_generator() -> str:
144144
return environ.get(OTEL_PYTHON_ID_GENERATOR, _DEFAULT_ID_GENERATOR)
145145

146146
def _get_log_level() -> int:
147-
return _OTEL_LOG_LEVEL_BY_NAME.get(environ.get(OTEL_LOG_LEVEL, "notset").lower().strip(), logging.NOTSET)
147+
return _OTEL_PYTHON_LOG_LEVEL_BY_NAME.get(environ.get(OTEL_PYTHON_LOG_LEVEL, "notset").lower().strip(), logging.NOTSET)
148148

149149

150150
def _get_exporter_entry_point(
@@ -273,7 +273,7 @@ def _init_logging(
273273
logger_provider=provider
274274
)
275275
# Log level
276-
if OTEL_LOG_LEVEL in environ:
276+
if OTEL_PYTHON_LOG_LEVEL in environ:
277277
handler.setLevel(_get_log_level())
278278
# Log format
279279
if OTEL_PYTHON_LOG_FORMAT in environ:

opentelemetry-sdk/tests/test_configurator.py

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -681,7 +681,7 @@ def test_logging_init_exporter(self):
681681
environ,
682682
{
683683
"OTEL_RESOURCE_ATTRIBUTES": "service.name=otlp-service",
684-
"OTEL_LOG_LEVEL": "CUSTOM_LOG_LEVEL",
684+
"OTEL_PYTHON_LOG_LEVEL": "CUSTOM_LOG_LEVEL",
685685
},
686686
clear=True,
687687
)
@@ -718,7 +718,7 @@ def test_logging_init_exporter_level_under(self, log_level_mock):
718718
environ,
719719
{
720720
"OTEL_RESOURCE_ATTRIBUTES": "service.name=otlp-service",
721-
"OTEL_LOG_LEVEL": "CUSTOM_LOG_LEVEL",
721+
"OTEL_PYTHON_LOG_LEVEL": "CUSTOM_LOG_LEVEL",
722722
},
723723
clear=True,
724724
)
@@ -821,35 +821,35 @@ def test_logging_init_exporter_without_handler_setup(self):
821821
self.fail()
822822

823823
@patch.dict(environ, {}, clear=True)
824-
def test_otel_log_level_by_name_default(self):
824+
def test_OTEL_PYTHON_LOG_LEVEL_by_name_default(self):
825825
self.assertEqual(_get_log_level(), NOTSET)
826826

827-
@patch.dict(environ, {"OTEL_LOG_LEVEL": "NOTSET "}, clear=True)
828-
def test_otel_log_level_by_name_notset(self):
827+
@patch.dict(environ, {"OTEL_PYTHON_LOG_LEVEL": "NOTSET "}, clear=True)
828+
def test_OTEL_PYTHON_LOG_LEVEL_by_name_notset(self):
829829
self.assertEqual(_get_log_level(), NOTSET)
830830

831-
@patch.dict(environ, {"OTEL_LOG_LEVEL": " DeBug "}, clear=True)
832-
def test_otel_log_level_by_name_debug(self):
831+
@patch.dict(environ, {"OTEL_PYTHON_LOG_LEVEL": " DeBug "}, clear=True)
832+
def test_OTEL_PYTHON_LOG_LEVEL_by_name_debug(self):
833833
self.assertEqual(_get_log_level(), DEBUG)
834834

835-
@patch.dict(environ, {"OTEL_LOG_LEVEL": " info "}, clear=True)
836-
def test_otel_log_level_by_name_info(self):
835+
@patch.dict(environ, {"OTEL_PYTHON_LOG_LEVEL": " info "}, clear=True)
836+
def test_OTEL_PYTHON_LOG_LEVEL_by_name_info(self):
837837
self.assertEqual(_get_log_level(), INFO)
838838

839-
@patch.dict(environ, {"OTEL_LOG_LEVEL": " warn"}, clear=True)
840-
def test_otel_log_level_by_name_warn(self):
839+
@patch.dict(environ, {"OTEL_PYTHON_LOG_LEVEL": " warn"}, clear=True)
840+
def test_OTEL_PYTHON_LOG_LEVEL_by_name_warn(self):
841841
self.assertEqual(_get_log_level(), WARNING)
842842

843-
@patch.dict(environ, {"OTEL_LOG_LEVEL": " warnING "}, clear=True)
844-
def test_otel_log_level_by_name_warning(self):
843+
@patch.dict(environ, {"OTEL_PYTHON_LOG_LEVEL": " warnING "}, clear=True)
844+
def test_OTEL_PYTHON_LOG_LEVEL_by_name_warning(self):
845845
self.assertEqual(_get_log_level(), WARNING)
846846

847-
@patch.dict(environ, {"OTEL_LOG_LEVEL": " eRroR"}, clear=True)
848-
def test_otel_log_level_by_name_error(self):
847+
@patch.dict(environ, {"OTEL_PYTHON_LOG_LEVEL": " eRroR"}, clear=True)
848+
def test_OTEL_PYTHON_LOG_LEVEL_by_name_error(self):
849849
self.assertEqual(_get_log_level(), ERROR)
850850

851-
@patch.dict(environ, {"OTEL_LOG_LEVEL": "foobar"}, clear=True)
852-
def test_otel_log_level_by_name_invalid(self):
851+
@patch.dict(environ, {"OTEL_PYTHON_LOG_LEVEL": "foobar"}, clear=True)
852+
def test_OTEL_PYTHON_LOG_LEVEL_by_name_invalid(self):
853853
self.assertEqual(_get_log_level(), NOTSET)
854854

855855
@patch.dict(

0 commit comments

Comments
 (0)