optimistic_locking leaves lock column in changed_columns after every save

[sterlzbd]

Basically, the optimistic_locking plugin seems to always leave the lock column in changed_columns where as other columns that were updated are removed. I expected that after a successful save_changes, nothing would be left in the changed_columns.

Here is a basic example of what I'm talking about

DB.create_table :albums do
  primary_key :id
  column :title, :text
  column :lock_version, :integer, null: false, default: 0
end

class Album < Sequel::Model
  plugin :optimistic_locking
end

puts "Album.create"
album = Album.create title: "First Title"
puts "album.changed_columns: #{album.changed_columns}"
puts "album.lock_version: #{album.lock_version}"

puts
puts "album.update"
album.update title: "Second Title"
puts "album.changed_columns: #{album.changed_columns}"
puts "album.lock_version: #{album.lock_version}"

puts
puts "album.save_changes"
album.save_changes
puts "album.changed_columns: #{album.changed_columns}"
puts "album.lock_version: #{album.lock_version}"

and the output with logging enabled

Album.create
D, [2024-07-29T17:25:06.645096 #55363] DEBUG -- : (0.000278s) BEGIN
D, [2024-07-29T17:25:06.645959 #55363] DEBUG -- : (0.000542s) INSERT INTO "albums" ("title") VALUES ('First Title') RETURNING *
D, [2024-07-29T17:25:06.647421 #55363] DEBUG -- : (0.001305s) COMMIT
album.changed_columns: []
album.lock_version: 0

album.update
D, [2024-07-29T17:25:06.648546 #55363] DEBUG -- : (0.000154s) BEGIN
D, [2024-07-29T17:25:06.651072 #55363] DEBUG -- : (0.000447s) UPDATE "albums" SET "title" = 'Second Title', "lock_version" = 1 WHERE (("id" = 1) AND ("lock_version" = 0))
D, [2024-07-29T17:25:06.651928 #55363] DEBUG -- : (0.000658s) COMMIT
album.changed_columns: [:lock_version]
album.lock_version: 1

album.save_changes
D, [2024-07-29T17:25:06.652429 #55363] DEBUG -- : (0.000147s) BEGIN
D, [2024-07-29T17:25:06.653041 #55363] DEBUG -- : (0.000432s) UPDATE "albums" SET "lock_version" = 2 WHERE (("id" = 1) AND ("lock_version" = 1))
D, [2024-07-29T17:25:06.654022 #55363] DEBUG -- : (0.000895s) COMMIT
album.changed_columns: [:lock_version]
album.lock_version: 2

I'm not sure if this is intentional but it was a surprise to me. Thanks for taking a look!

[jeremyevans]

Thanks for the report. It seems reasonable to remove the lock column from changed_columns. I'll work on that.

[sterlzbd]

OK great, thank you

[jeremyevans]

Fixed in d6f4faa