improve code

Author: nyamsprod

src/Domain.php

@@ -181,9 +181,6 @@ public function getDomain()
      *
      * This method should return null if the registrable domain is the same as the public suffix.
      *
-     * @see https://publicsuffix.org/list/
-     * @see https://raw.githubusercontent.com/publicsuffix/list/master/tests/test_psl.txt
-     *
      * @return string|null registrable domain
      */
     public function getRegistrableDomain()
@@ -219,8 +216,6 @@ public function getPublicSuffix()
     /**
      * Tells whether the public suffix has a matching rule in a Public Suffix List.
      *
-     * @see https://publicsuffix.org/learn/
-     *
      * @return bool
      */
     public function isKnown(): bool
@@ -231,8 +226,6 @@ public function isKnown(): bool
     /**
      * Tells whether the public suffix has a matching rule in a Public Suffix List ICANN Section.
      *
-     * @see https://publicsuffix.org/learn/
-     *
      * @return bool
      */
     public function isICANN(): bool
@@ -243,8 +236,6 @@ public function isICANN(): bool
     /**
      * Tells whether the public suffix has a matching rule in a Public Suffix List Private Section.
      *
-     * @see https://publicsuffix.org/learn/
-     *
      * @return bool
      */
     public function isPrivate(): bool

src/Manager.php

@@ -104,6 +104,8 @@ public function refreshRules(string $source_url = self::PSL_URL): bool
             return false;
         }
 
-        return $this->cache->set($this->getCacheKey($source_url), json_encode($rules));
+        $cacheKey = $this->getCacheKey($source_url);
+
+        return $this->cache->set($cacheKey, json_encode($rules));
     }
 }

src/PublicSuffix.php

@@ -24,9 +24,8 @@
  * it for this purpose, please do not bake static copies of the PSL into your
  * software with no update mechanism."
  *
- * @author Ignace Nyamagana Butera <[email protected]>
- *
- * @internal
+ * @author   Ignace Nyamagana Butera <[email protected]>
+ * @internal used internally to represent a public suffix
  */
 final class PublicSuffix implements Countable
 {
@@ -77,8 +76,6 @@ public function count()
     /**
      * Tells whether the public suffix has a matching rule in a Public Suffix List.
      *
-     * @see https://publicsuffix.org/learn/
-     *
      * @return bool
      */
     public function isKnown(): bool
@@ -89,8 +86,6 @@ public function isKnown(): bool
     /**
      * Tells whether the public suffix has a matching rule in a Public Suffix List ICANN Section.
      *
-     * @see https://publicsuffix.org/learn/
-     *
      * @return bool
      */
     public function isICANN(): bool
@@ -101,8 +96,6 @@ public function isICANN(): bool
     /**
      * Tells whether the public suffix has a matching rule in a Public Suffix List Private Section.
      *
-     * @see https://publicsuffix.org/learn/
-     *
      * @return bool
      */
     public function isPrivate(): bool

src/Rules.php

@@ -86,7 +86,7 @@ private function isMatchable($domain): bool
      *
      * "The domain must be canonicalized in the normal way for hostnames - lower-case, Punycode."
      *
-     * @see http://www.ietf.org/rfc/rfc3492.txt
+     * @see https://tools.ietf.org/html/rfc3492
      *
      * @param string $domain
      *
@@ -118,7 +118,6 @@ private function findPublicSuffix(string $type, string $domain): PublicSuffix
     {
         $normalizedDomain = $this->normalize($domain);
         $reverseLabels = array_reverse(explode('.', $normalizedDomain));
-
         $resultIcann = $this->findPublicSuffixFromSection(self::ICANN_DOMAINS, $reverseLabels);
         if (self::ICANN_DOMAINS === $type) {
             return $resultIcann;
@@ -193,7 +192,6 @@ private function handleNoMatches(string $domain): PublicSuffix
     {
         $labels = explode('.', $domain);
         $publicSuffix = array_pop($labels);
-
         if ($this->isPunycoded($domain)) {
             return new PublicSuffix($publicSuffix);
         }