improve PublicSuffix validation

Author: nyamsprod

src/PublicSuffix.php

@@ -100,7 +100,7 @@ public function __construct($publicSuffix = null, string $section = '')
      */
     private function setSection(string $section): string
     {
-        if (in_array($this->publicSuffix, ['', null], true)) {
+        if (in_array($this->publicSuffix, ['', null], true) || '.' === substr($this->publicSuffix, -1, 1)) {
             return '';
         }
 

tests/PublicSuffixTest.php

@@ -48,6 +48,41 @@ public function testPSToUnicodeWithUrlEncode()
         $this->assertSame('bébe', (new PublicSuffix('b%C3%A9be'))->toUnicode()->getContent());
     }
 
+    /**
+     * @covers ::__construct
+     * @covers ::setLabels
+     * @covers ::setSection
+     * @covers ::isKnown
+     * @covers ::isICANN
+     * @covers ::isPrivate
+     * @dataProvider PSProvider
+     *
+     * @param string|null $publicSuffix
+     * @param string      $section
+     * @param bool        $isKnown
+     * @param bool        $isIcann
+     * @param bool        $isPrivate
+     */
+    public function testSetSection($publicSuffix, string $section, bool $isKnown, bool $isIcann, bool $isPrivate)
+    {
+        $ps = new PublicSuffix($publicSuffix, $section);
+
+        $this->assertSame($isKnown, $ps->isKnown());
+        $this->assertSame($isIcann, $ps->isICANN());
+        $this->assertSame($isPrivate, $ps->isPrivate());
+    }
+
+    public function PSProvider()
+    {
+        return [
+            [null, PublicSuffix::ICANN_DOMAINS, false, false, false],
+            ['', PublicSuffix::ICANN_DOMAINS, false, false, false],
+            ['foo', PublicSuffix::ICANN_DOMAINS, true, true, false],
+            ['foo', PublicSuffix::PRIVATE_DOMAINS, true, false, true],
+            ['foo.', PublicSuffix::PRIVATE_DOMAINS, false, false, false],
+        ];
+    }
+
     /**
      * @covers ::__construct
      * @covers ::setLabels