Add more control over IDNA options

Author: nyamsprod

src/Rules.php

@@ -143,6 +143,30 @@ public static function __set_state(array $properties): self
         );
     }
 
+    /**
+     * Set IDNA_* options for functions idn_to_ascii.
+     *
+     * @see https://www.php.net/manual/en/intl.constants.php
+     *
+     * @return int
+     */
+    public function getAsciiIDNAOption(): int
+    {
+        return $this->asciiIDNAOption;
+    }
+    
+    /**
+     * Set IDNA_* options for functions idn_to_utf8.
+     *
+     * @see https://www.php.net/manual/en/intl.constants.php
+     *
+     * @return int
+     */
+    public function getUnicodeIDNAOption(): int
+    {
+        return $this->unicodeIDNAOption;
+    }
+    
     /**
      * Determines the public suffix for a given domain.
      *

src/TopLevelDomains.php

@@ -176,6 +176,30 @@ public function getModifiedDate(): DateTimeImmutable
         return $this->modifiedDate;
     }
 
+    /**
+     * Set IDNA_* options for functions idn_to_ascii.
+     *
+     * @see https://www.php.net/manual/en/intl.constants.php
+     *
+     * @return int
+     */
+    public function getAsciiIDNAOption(): int
+    {
+        return $this->asciiIDNAOption;
+    }
+    
+    /**
+     * Set IDNA_* options for functions idn_to_utf8.
+     *
+     * @see https://www.php.net/manual/en/intl.constants.php
+     *
+     * @return int
+     */
+    public function getUnicodeIDNAOption(): int
+    {
+        return $this->unicodeIDNAOption;
+    }
+    
     /**
      * {@inheritdoc}
      */

tests/RulesTest.php

@@ -644,6 +644,10 @@ public function testPublicSuffixSpec()
         $this->checkPublicSuffix('xn--fiqs8s', null);
     }
 
+    /**
+     * @covers ::getAsciiIDNAOption
+     * @covers ::getUnicodeIDNAOption
+     */
     public function testResolveWithIDNAOptions()
     {
         $resolvedByDefault = $this->rules->resolve('foo.de', Rules::ICANN_DOMAINS);
@@ -655,7 +659,7 @@ public function testResolveWithIDNAOptions()
         $rules = $manager->getRules(Manager::PSL_URL, null, 16, 32);
         $resolved = $rules->resolve('foo.de', Rules::ICANN_DOMAINS);
         self::assertSame(
-            [16, 32],
+            [$rules->getAsciiIDNAOption(), $rules->getUnicodeIDNAOption()],
             [$resolved->getAsciiIDNAOption(), $resolved->getUnicodeIDNAOption()]
         );
     }

tests/TopLevelDomainsTest.php

@@ -95,12 +95,21 @@ public function testGetterProperties()
     }
 
     /**
+     * @covers ::getAsciiIDNAOption
+     * @covers ::getUnicodeIDNAOption
      * @covers ::withIDNAOptions
      */
     public function testwithIDNAOptions()
     {
-        self::assertSame($this->collection, $this->collection->withIDNAOptions(IDNA_DEFAULT, IDNA_DEFAULT));
-        self::assertNotEquals($this->collection, $this->collection->withIDNAOptions(IDNA_DEFAULT, 128));
+        self::assertSame($this->collection, $this->collection->withIDNAOptions(
+            $this->collection->getAsciiIDNAOption(),
+            $this->collection->getUnicodeIDNAOption()
+        ));
+
+        self::assertNotEquals($this->collection, $this->collection->withIDNAOptions(
+            $this->collection->getAsciiIDNAOption(),
+            128
+        ));
     }
 
     /**