Update package configuration

- explicit import of functions and constants
- update Unit test to use self:: instead of $this
- add PHP7.3 tests in travis configuration
- update PHP Code Fixer settings to be more inline with PSR-12

Author: nyamsprod

.php_cs

@@ -34,7 +34,7 @@ return PhpCsFixer\Config::create()
         'no_leading_import_slash' => true,
         'no_trailing_comma_in_singleline_array' => true,
         'no_unused_imports' => true,
-        'ordered_imports' => ['imports_order' => null, 'sort_algorithm' => 'alpha'],
+        'ordered_imports' => ['imports_order' => ['class', 'function', 'const'], 'sort_algorithm' => 'alpha'],
         'phpdoc_add_missing_param_annotation' => ['only_untyped' => false],
         'phpdoc_align' => true,
         'phpdoc_no_empty_return' => true,

.travis.yml

@@ -10,6 +10,8 @@ matrix:
       env: VALIDATE_CODING_STYLE=false RUN_PHPSTAN=false IGNORE_PLATFORMS=false
     - php: 7.2
       env: VALIDATE_CODING_STYLE=true RUN_PHPSTAN=true IGNORE_PLATFORMS=false
+    - php: 7.3
+      env: VALIDATE_CODING_STYLE=false RUN_PHPSTAN=false IGNORE_PLATFORMS=true
     - php: nightly
       env: VALIDATE_CODING_STYLE=false RUN_PHPSTAN=false IGNORE_PLATFORMS=true
   allow_failures:

src/Cache.php

@@ -20,6 +20,27 @@
 use Generator;
 use Psr\SimpleCache\CacheInterface;
 use Traversable;
+use function chmod;
+use function dirname;
+use function file_exists;
+use function file_get_contents;
+use function filemtime;
+use function get_class;
+use function gettype;
+use function is_array;
+use function is_int;
+use function is_object;
+use function is_writable;
+use function mkdir;
+use function realpath;
+use function rename;
+use function sprintf;
+use function time;
+use function touch;
+use function uniqid;
+use function unlink;
+use function unserialize;
+use const DIRECTORY_SEPARATOR;
 
 /**
  * A simple file-based PSR-16 cache implementation.

src/Converter.php

@@ -17,6 +17,11 @@
 
 use Pdp\Exception\CouldNotLoadRules;
 use SplTempFileObject;
+use function array_pop;
+use function explode;
+use function preg_match;
+use function strpos;
+use function substr;
 
 /**
  * Public Suffix List Parser.

src/CurlHttpClient.php

@@ -15,6 +15,20 @@
 
 namespace Pdp;
 
+use function curl_close;
+use function curl_errno;
+use function curl_error;
+use function curl_exec;
+use function curl_init;
+use function curl_setopt_array;
+use const CURLE_OK;
+use const CURLOPT_FAILONERROR;
+use const CURLOPT_FOLLOWLOCATION;
+use const CURLOPT_HTTPGET;
+use const CURLOPT_RETURNTRANSFER;
+use const CURLOPT_SSL_VERIFYHOST;
+use const CURLOPT_SSL_VERIFYPEER;
+
 final class CurlHttpClient implements HttpClient
 {
     /**

src/Domain.php

@@ -21,6 +21,22 @@
 use Pdp\Exception\InvalidLabel;
 use Pdp\Exception\InvalidLabelKey;
 use TypeError;
+use function array_count_values;
+use function array_keys;
+use function array_reverse;
+use function array_slice;
+use function array_unshift;
+use function count;
+use function explode;
+use function gettype;
+use function implode;
+use function in_array;
+use function ksort;
+use function preg_match;
+use function sprintf;
+use function strlen;
+use function strpos;
+use function substr;
 
 /**
  * Domain Value Object.

src/IDNAConverterTrait.php

@@ -17,6 +17,36 @@
 
 use Pdp\Exception\InvalidDomain;
 use TypeError;
+use function array_reverse;
+use function explode;
+use function gettype;
+use function idn_to_ascii;
+use function idn_to_utf8;
+use function implode;
+use function is_scalar;
+use function iterator_to_array;
+use function method_exists;
+use function preg_match;
+use function rawurldecode;
+use function sprintf;
+use function strpos;
+use function strtolower;
+use const FILTER_FLAG_IPV4;
+use const FILTER_VALIDATE_IP;
+use const IDNA_ERROR_BIDI;
+use const IDNA_ERROR_CONTEXTJ;
+use const IDNA_ERROR_DISALLOWED;
+use const IDNA_ERROR_DOMAIN_NAME_TOO_LONG;
+use const IDNA_ERROR_EMPTY_LABEL;
+use const IDNA_ERROR_HYPHEN_3_4;
+use const IDNA_ERROR_INVALID_ACE_LABEL;
+use const IDNA_ERROR_LABEL_HAS_DOT;
+use const IDNA_ERROR_LABEL_TOO_LONG;
+use const IDNA_ERROR_LEADING_COMBINING_MARK;
+use const IDNA_ERROR_LEADING_HYPHEN;
+use const IDNA_ERROR_PUNYCODE;
+use const IDNA_ERROR_TRAILING_HYPHEN;
+use const INTL_IDNA_VARIANT_UTS46;
 
 /**
  * @internal Domain name validator

src/Installer.php

@@ -17,6 +17,14 @@
 
 use Composer\Script\Event;
 use Throwable;
+use function dirname;
+use function extension_loaded;
+use function fwrite;
+use function implode;
+use function is_dir;
+use const PHP_EOL;
+use const STDERR;
+use const STDOUT;
 
 /**
  * A class to manage PSL ICANN Section rules updates.

src/Manager.php

@@ -22,6 +22,20 @@
 use Pdp\Exception\CouldNotLoadTLDs;
 use Psr\SimpleCache\CacheInterface;
 use TypeError;
+use function filter_var;
+use function gettype;
+use function is_object;
+use function is_string;
+use function json_decode;
+use function json_encode;
+use function json_last_error;
+use function json_last_error_msg;
+use function md5;
+use function sprintf;
+use function strtolower;
+use const DATE_ATOM;
+use const FILTER_VALIDATE_INT;
+use const JSON_ERROR_NONE;
 
 /**
  * Public Suffix List Manager.

src/PublicSuffix.php

@@ -18,6 +18,14 @@
 use JsonSerializable;
 use Pdp\Exception\CouldNotResolvePublicSuffix;
 use Pdp\Exception\InvalidDomain;
+use function array_keys;
+use function array_reverse;
+use function count;
+use function explode;
+use function implode;
+use function in_array;
+use function reset;
+use function sprintf;
 
 /**
  * Public Suffix Value Object.
@@ -105,7 +113,7 @@ public function __construct($publicSuffix = null, string $section = '')
      */
     private function setPublicSuffix()
     {
-        if (empty($this->labels)) {
+        if ([] === $this->labels) {
             return null;
         }