Makes services readonly

Author: nyamsprod

.php-cs-fixer.php

@@ -27,7 +27,7 @@
             'remove_inheritdoc' => true,
             'allow_unused_params' => false,
         ],
-        'no_trailing_comma_in_singleline_array' => true,
+        'no_trailing_comma_in_singleline' => true,
         'no_unused_imports' => true,
         'ordered_imports' => ['imports_order' => ['class', 'function', 'const'], 'sort_algorithm' => 'alpha'],
         'phpdoc_add_missing_param_annotation' => ['only_untyped' => true],

src/Rules.php

@@ -32,7 +32,7 @@ final class Rules implements PublicSuffixList
     /**
      * @param array{ICANN_DOMAINS: array<array>, PRIVATE_DOMAINS: array<array>} $rules
      */
-    private function __construct(private array $rules)
+    private function __construct(private readonly array $rules)
     {
     }
 

src/Suffix.php

@@ -16,7 +16,7 @@ final class Suffix implements EffectiveTopLevelDomain
 
     private function __construct(
         private DomainName $domain,
-        private string $section
+        private readonly string $section
     ) {
     }
 
@@ -132,18 +132,12 @@ public function toString(): string
 
     public function toAscii(): self
     {
-        $clone = clone $this;
-        $clone->domain = $this->domain->toAscii();
-
-        return $clone;
+        return new self($this->domain->toAscii(), $this->section);
     }
 
     public function toUnicode(): self
     {
-        $clone = clone $this;
-        $clone->domain = $this->domain->toUnicode();
-
-        return $clone;
+        return new self($this->domain->toUnicode(), $this->section);
     }
 
     public function normalize(DomainName $domain): self
@@ -153,9 +147,6 @@ public function normalize(DomainName $domain): self
             $newDomain = $newDomain->toAscii();
         }
 
-        $clone = clone $this;
-        $clone->domain = $newDomain;
-
-        return $clone;
+        return new self($newDomain, $this->section);
     }
 }

src/TopLevelDomains.php

@@ -22,9 +22,9 @@ final class TopLevelDomains implements TopLevelDomainList
      * @param array<string, int> $records
      */
     private function __construct(
-        private array $records,
-        private string $version,
-        private DateTimeImmutable $lastUpdated
+        private readonly array $records,
+        private readonly string $version,
+        private readonly DateTimeImmutable $lastUpdated
     ) {
     }