Skip to content

Commit 7b43d72

Browse files
committed
Remove isValid from domain constructors
1 parent ab1192c commit 7b43d72

File tree

2 files changed

+4
-18
lines changed

2 files changed

+4
-18
lines changed

src/Pdp/MatchedDomain.php

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,23 +25,16 @@ final class MatchedDomain implements Domain
2525
*/
2626
private $publicSuffix;
2727

28-
/**
29-
* @var bool
30-
*/
31-
private $isValid;
32-
3328
/**
3429
* New instance.
3530
*
3631
* @param string|null $domain
3732
* @param string|null $publicSuffix
38-
* @param bool $isValid
3933
*/
40-
public function __construct(string $domain = null, string $publicSuffix = null, bool $isValid = true)
34+
public function __construct(string $domain = null, string $publicSuffix = null)
4135
{
4236
$this->domain = $domain;
4337
$this->publicSuffix = $publicSuffix;
44-
$this->isValid = $isValid;
4538
}
4639

4740
/**
@@ -65,7 +58,7 @@ public function getPublicSuffix()
6558
*/
6659
public function isValid(): bool
6760
{
68-
return $this->isValid;
61+
return true;
6962
}
7063

7164
/**

src/Pdp/UnmatchedDomain.php

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -25,23 +25,16 @@ final class UnmatchedDomain implements Domain
2525
*/
2626
private $publicSuffix;
2727

28-
/**
29-
* @var bool
30-
*/
31-
private $isValid;
32-
3328
/**
3429
* New instance.
3530
*
3631
* @param string|null $domain
3732
* @param string|null $publicSuffix
38-
* @param bool $isValid
3933
*/
40-
public function __construct(string $domain = null, string $publicSuffix = null, bool $isValid = false)
34+
public function __construct(string $domain = null, string $publicSuffix = null)
4135
{
4236
$this->domain = $domain;
4337
$this->publicSuffix = $publicSuffix;
44-
$this->isValid = $isValid;
4538
}
4639

4740
/**
@@ -65,7 +58,7 @@ public function getPublicSuffix()
6558
*/
6659
public function isValid(): bool
6760
{
68-
return $this->isValid;
61+
return false;
6962
}
7063

7164
/**

0 commit comments

Comments
 (0)