Improve codebase against PHPStan results

Author: nyamsprod

phpstan.src.neon

@@ -6,6 +6,12 @@ parameters:
     ignoreErrors:
         - message: '#Call to function is_iterable\(\) with iterable will always evaluate to true.#'
           path: src/Cache.php
+        - message: '#Call to function is_string\(\) with string will always evaluate to true.#'
+          path: src/Cache.php
+        - message: '#Call to function is_object\(\) with \*NEVER\* will always evaluate to true.#'
+          path: src/Cache.php
+        - message: '#Else branch is unreachable because ternary operator condition is always true.#'
+          path: src/Cache.php
         - message: '#Property Pdp\\TopLevelDomains::\$modifiedDate \(DateTimeImmutable\) does not accept DateTimeInterface.#'
           path: src/TopLevelDomains.php
     reportUnmatchedIgnoredErrors: true

src/Domain.php

@@ -187,10 +187,16 @@ private function normalize(PublicSuffix $subject): PublicSuffix
         }
 
         if (1 !== preg_match(self::REGEXP_IDN_PATTERN, $this->domain)) {
-            return $subject->toAscii();
+            /** @var PublicSuffix $result */
+            $result = $subject->toAscii();
+
+            return $result;
         }
 
-        return $subject->toUnicode();
+        /** @var PublicSuffix $result */
+        $result = $subject->toUnicode();
+
+        return $result;
     }
 
     /**

tests/DomainTest.php

@@ -30,7 +30,7 @@
 use const IDNA_NONTRANSITIONAL_TO_UNICODE;
 
 /**
- * @coversDefaultClass Pdp\Domain
+ * @coversDefaultClass \Pdp\Domain
  */
 class DomainTest extends TestCase
 {
@@ -239,6 +239,7 @@ public function testToIDN(
         self::assertSame($expectedDomain, $domain->getDomain());
         self::assertSame($expectedSuffix, $domain->getPublicSuffix());
 
+        /** @var Domain $domainIDN */
         $domainIDN = $domain->toUnicode();
         self::assertSame($expectedIDNDomain, $domainIDN->getDomain());
         self::assertSame($expectedIDNSuffix, $domainIDN->getPublicSuffix());
@@ -339,6 +340,7 @@ public function testToAscii(
         self::assertSame($expectedDomain, $domain->getDomain());
         self::assertSame($expectedSuffix, $domain->getPublicSuffix());
 
+        /** @var Domain $domainIDN */
         $domainIDN = $domain->toAscii();
         self::assertSame($expectedAsciiDomain, $domainIDN->getDomain());
         self::assertSame($expectedAsciiSuffix, $domainIDN->getPublicSuffix());
@@ -1114,11 +1116,13 @@ public function testInstanceCreationWithCustomIDNAOptions(): void
             IDNA_NONTRANSITIONAL_TO_UNICODE
         );
 
+        /** @var Domain $instance */
         $instance = $domain->toAscii();
         self::assertSame(
             [$domain->getAsciiIDNAOption(), $domain->getUnicodeIDNAOption()],
             [$instance->getAsciiIDNAOption(), $instance->getUnicodeIDNAOption()]
         );
+        /** @var Domain $instance */
         $instance = $domain->toUnicode();
         self::assertSame(
             [$domain->getAsciiIDNAOption(), $domain->getUnicodeIDNAOption()],

tests/PublicSuffixTest.php

@@ -299,6 +299,7 @@ public function testResolveWithCustomIDNAOptions(
         self::assertSame($expectedContent, $publicSuffix->getContent());
         self::assertSame($expectedAscii, $publicSuffix->toAscii()->getContent());
         self::assertSame($expectedUnicode, $publicSuffix->toUnicode()->getContent());
+        /** @var PublicSuffix $instance */
         $instance = $publicSuffix->toUnicode();
         self::assertSame(
             [$publicSuffix->getAsciiIDNAOption(), $publicSuffix->getUnicodeIDNAOption()],