deprecate IDNAConverterTrait::setLabels

Author: nyamsprod

CHANGELOG.md

@@ -2,7 +2,7 @@
 
 All Notable changes to `PHP Domain Parser` **5.x** series will be documented in this file
 
-# 5.5.0 - 2019-04-13
+# 5.5.0 - 2019-04-14
 
 ### Added
 
@@ -19,11 +19,11 @@ All Notable changes to `PHP Domain Parser` **5.x** series will be documented in
 
 ### Deprecated
 
-- None
+- `IDNAConverterTrait::setLabels` replaced by `IDNAConverterTrait::parse` (internal)
 
 ### Removed
 
-- IDNAConverterTrait::setLabels (internal)
+- None
 
 # 5.4.0 - 2018-11-22
 

src/IDNAConverterTrait.php

@@ -188,7 +188,30 @@ private function idnToUnicode(string $domain, int $option = IDNA_DEFAULT): strin
      * Filter and format the domain to ensure it is valid.
      * Returns an array containing the formatted domain name in lowercase
      * with its associated labels in reverse order
-     * For example: parse('wWw.uLb.Ac.be') should return ['www.ulb.ac.be', ['be', 'ac', 'ulb', 'www']];.
+     * For example: parse('wWw.uLb.Ac.be') should return ['be', 'ac', 'ulb', 'www'];.
+     *
+     * @deprecated
+     *
+     * @codeCoverageIgnore
+     *
+     * @param mixed $domain
+     *
+     * @throws InvalidDomain If the domain is invalid
+     *
+     * @return string[]
+     */
+    private function setLabels($domain = null): array
+    {
+        return $this->parse($domain, IDNA_DEFAULT, IDNA_DEFAULT)['labels'];
+    }
+
+    /**
+     * Parse and format the domain to ensure it is valid.
+     * Returns an array containing the formatted domain name labels
+     * and the domain transitional information.
+     *
+     * For example: parse('wWw.uLb.Ac.be') should return
+     *     ['labels' => ['be', 'ac', 'ulb', 'www'], 'isTransitionalDifferant' => false];.
      *
      * @param mixed $domain
      * @param int   $asciiOption