remove iterator_to_array usage

nyamsprod · nyamsprod · commit fd11f5783e0b · 2023-02-20T21:54:09.000+01:00
diff --git a/src/DomainTest.php b/src/DomainTest.php
@@ -45,7 +45,7 @@ public function testDomainInternalPhpMethod(): void
         /** @var Domain $generateDomain */
         $generateDomain = eval('return '.var_export($domain, true).';');
         self::assertEquals($domain, $generateDomain);
-        self::assertSame(['be', 'ac', 'ulb', 'www'], iterator_to_array($domain));
+        self::assertSame(['be', 'ac', 'ulb', 'www'], [...$domain]);
         self::assertEquals('"www.ulb.ac.be"', json_encode($domain));
         self::assertSame('www.ulb.ac.be', $domain->toString());
     }
@@ -58,7 +58,7 @@ public function testCountable(?string $domain, int $nbLabels, array $labels): vo
     {
         $domain = Domain::fromIDNA2008($domain);
         self::assertCount($nbLabels, $domain);
-        self::assertSame($labels, iterator_to_array($domain));
+        self::assertSame($labels, [...$domain]);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ public function testDomainInternalPhpMethod(): void`
`45`	`45`	`/** @var Domain $generateDomain */`
`46`	`46`	`$generateDomain = eval('return '.var_export($domain, true).';');`
`47`	`47`	`self::assertEquals($domain, $generateDomain);`
`48`		`- self::assertSame(['be', 'ac', 'ulb', 'www'], iterator_to_array($domain));`
	`48`	`+ self::assertSame(['be', 'ac', 'ulb', 'www'], [...$domain]);`
`49`	`49`	`self::assertEquals('"www.ulb.ac.be"', json_encode($domain));`
`50`	`50`	`self::assertSame('www.ulb.ac.be', $domain->toString());`
`51`	`51`	`}`
`@@ -58,7 +58,7 @@ public function testCountable(?string $domain, int $nbLabels, array $labels): vo`
`58`	`58`	`{`
`59`	`59`	`$domain = Domain::fromIDNA2008($domain);`
`60`	`60`	`self::assertCount($nbLabels, $domain);`
`61`		`- self::assertSame($labels, iterator_to_array($domain));`
	`61`	`+ self::assertSame($labels, [...$domain]);`
`62`	`62`	`}`
`63`	`63`
`64`	`64`	`/**`