bugfix issue #230

Author: nyamsprod

CHANGELOG.md

@@ -19,6 +19,7 @@ All Notable changes to `PHP Domain Parser` **5.x** series will be documented in
 ### Fixed
 
 - `Pdp\IDNAConverterTrait::setLabels` improve IDN domain handling
+- `Pdp\IDNAConverterTrait` throws a `UnexpectedValueException` if the Intl extension is misconfigured see [#230](https://github.com/jeremykendall/php-domain-parser/issues/230)
 
 ### Deprecated
 

src/IDNAConverterTrait.php

@@ -17,6 +17,7 @@
 
 use Pdp\Exception\InvalidDomain;
 use TypeError;
+use UnexpectedValueException;
 use function array_reverse;
 use function explode;
 use function gettype;
@@ -119,6 +120,12 @@ private function idnToAscii(string $domain): string
             throw new InvalidDomain(sprintf('The host `%s` is invalid : %s', $domain, self::getIdnErrors($arr['errors'])));
         }
 
+        // @codeCoverageIgnoreStart
+        if (false === $output) {
+            throw new UnexpectedValueException(sprintf('The Intl extension is misconfigured for %s, please correct this issue before proceeding.', PHP_OS));
+        }
+        // @codeCoverageIgnoreEnd
+
         if (false === strpos($output, '%')) {
             return $output;
         }
@@ -140,11 +147,17 @@ private function idnToAscii(string $domain): string
     private function idnToUnicode(string $domain): string
     {
         $output = idn_to_utf8($domain, 0, INTL_IDNA_VARIANT_UTS46, $arr);
-        if (0 === $arr['errors']) {
-            return $output;
+        if (0 !== $arr['errors']) {
+            throw new InvalidDomain(sprintf('The host `%s` is invalid : %s', $domain, self::getIdnErrors($arr['errors'])));
+        }
+
+        // @codeCoverageIgnoreStart
+        if (false === $output) {
+            throw new UnexpectedValueException(sprintf('The Intl extension is misconfigured for %s, please correct this issue before proceeding.', PHP_OS));
         }
+        // @codeCoverageIgnoreEnd
 
-        throw new InvalidDomain(sprintf('The host `%s` is invalid : %s', $domain, self::getIdnErrors($arr['errors'])));
+        return $output;
     }
 
     /**