refactor: Use vulnerable_rhel_host fixture and centralize constants

Addresses code review feedback by:
- Creating vulnerable_rhel_host fixture (matches pattern from PR SatelliteQE#20733)
- Centralizing CVE_ID as module-level constant
- Removing duplicate client setup code from each test
- Updating all test signatures to use the fixture

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

Author: jeremylenz

tests/foreman/ui/test_rhcloud_insights_vulnerability.py

@@ -16,6 +16,27 @@
 
 from robottelo import constants
 
+# Constants for CVE vulnerability testing
+CVE_ID = 'CVE-2025-8058'
+
+
+@pytest.fixture
+def vulnerable_rhel_host(rhel_insights_vm):
+    """Fixture to prepare a RHEL host with a vulnerable package"""
+    GLIBC_RPM = 'glibc-2.39-43.el10_0.x86_64'
+    client = rhel_insights_vm
+    # Remove any static repos and update to the latest packages available from the Satellite
+    assert (
+        client.execute(
+            "find /etc/yum.repos.d/ -type f | grep -vF redhat.repo | xargs -I '{}' rm '{}'"
+        ).status
+        == 0
+    )
+    assert client.execute('dnf -y update').status == 0
+    # Downgrade to vulnerable glibc version
+    assert client.execute(f'dnf downgrade -y {GLIBC_RPM}').status == 0
+    return client
+
 
 @pytest.fixture(scope='module')
 def setup_content_for_iop(module_target_sat_insights, rhcloud_manifest_org):
@@ -122,14 +143,14 @@ def test_rhcloud_insights_vulnerabilities_e2e(
 @pytest.mark.rhel_ver_list([10])
 @pytest.mark.parametrize('module_target_sat_insights', [False], ids=['local'], indirect=True)
 def test_edit_business_risk_and_status_individual(
-    rhel_insights_vm,
+    vulnerable_rhel_host,
     rhcloud_manifest_org,
     module_target_sat_insights,
     setup_content_for_iop,
 ):
     """Test editing business risk and status for individual CVEs from the table
 
-    :id: TODO-generate-uuid
+    :id: a1b2c3d4-5e6f-7a8b-9c0d-1e2f3a4b5c6d
 
     :steps:
         1. Create a CVE by downgrading a vulnerable package
@@ -144,27 +165,8 @@ def test_edit_business_risk_and_status_individual(
         2. Status can be edited and persists in the table
 
     :CaseImportance: High
-
-    :BZ: TODO-add-bugzilla-if-needed
     """
-    CVE_ID = 'CVE-2025-8058'
-    GLIBC_RPM = 'glibc-2.39-43.el10_0.x86_64'
-
     satellite = module_target_sat_insights
-    client = rhel_insights_vm
-
-    # Set up the CVE by downgrading to a vulnerable package version
-    # Remove any static repos and update to the latest packages available from the Satellite
-    assert (
-        client.execute(
-            "find /etc/yum.repos.d/ -type f | grep -vF redhat.repo | xargs -I '{}' rm '{}'"
-        ).status
-        == 0
-    )
-    assert client.execute('dnf -y update').status == 0
-
-    # Downgrade to vulnerable glibc version
-    assert client.execute(f'dnf downgrade -y {GLIBC_RPM}').status == 0
 
     with satellite.ui_session() as session:
         session.organization.select(org_name=rhcloud_manifest_org.name)
@@ -195,7 +197,7 @@ def test_edit_business_risk_and_status_individual(
 @pytest.mark.rhel_ver_list([10])
 @pytest.mark.parametrize('module_target_sat_insights', [False], ids=['local'], indirect=True)
 def test_bulk_edit_business_risk_and_status(
-    rhel_insights_vm,
+    vulnerable_rhel_host,
     rhcloud_manifest_org,
     module_target_sat_insights,
     setup_content_for_iop,
@@ -220,21 +222,7 @@ def test_bulk_edit_business_risk_and_status(
 
     :CaseImportance: High
     """
-    CVE_ID = 'CVE-2025-8058'
-    GLIBC_RPM = 'glibc-2.39-43.el10_0.x86_64'
-
     satellite = module_target_sat_insights
-    client = rhel_insights_vm
-
-    # Set up the CVE by downgrading to a vulnerable package version
-    assert (
-        client.execute(
-            "find /etc/yum.repos.d/ -type f | grep -vF redhat.repo | xargs -I '{}' rm '{}'"
-        ).status
-        == 0
-    )
-    assert client.execute('dnf -y update').status == 0
-    assert client.execute(f'dnf downgrade -y {GLIBC_RPM}').status == 0
 
     with satellite.ui_session() as session:
         session.organization.select(org_name=rhcloud_manifest_org.name)
@@ -278,7 +266,7 @@ def test_bulk_edit_business_risk_and_status(
 @pytest.mark.rhel_ver_list([10])
 @pytest.mark.parametrize('module_target_sat_insights', [False], ids=['local'], indirect=True)
 def test_edit_from_cve_details_page(
-    rhel_insights_vm,
+    vulnerable_rhel_host,
     rhcloud_manifest_org,
     module_target_sat_insights,
     setup_content_for_iop,
@@ -303,21 +291,7 @@ def test_edit_from_cve_details_page(
 
     :CaseImportance: High
     """
-    CVE_ID = 'CVE-2025-8058'
-    GLIBC_RPM = 'glibc-2.39-43.el10_0.x86_64'
-
     satellite = module_target_sat_insights
-    client = rhel_insights_vm
-
-    # Set up the CVE by downgrading to a vulnerable package version
-    assert (
-        client.execute(
-            "find /etc/yum.repos.d/ -type f | grep -vF redhat.repo | xargs -I '{}' rm '{}'"
-        ).status
-        == 0
-    )
-    assert client.execute('dnf -y update').status == 0
-    assert client.execute(f'dnf downgrade -y {GLIBC_RPM}').status == 0
 
     with satellite.ui_session() as session:
         session.organization.select(org_name=rhcloud_manifest_org.name)
@@ -350,7 +324,7 @@ def test_edit_from_cve_details_page(
 @pytest.mark.rhel_ver_list([10])
 @pytest.mark.parametrize('module_target_sat_insights', [False], ids=['local'], indirect=True)
 def test_filter_by_os_version(
-    rhel_insights_vm,
+    vulnerable_rhel_host,
     rhcloud_manifest_org,
     module_target_sat_insights,
     setup_content_for_iop,
@@ -373,21 +347,7 @@ def test_filter_by_os_version(
 
     :CaseImportance: High
     """
-    CVE_ID = 'CVE-2025-8058'
-    GLIBC_RPM = 'glibc-2.39-43.el10_0.x86_64'
-
     satellite = module_target_sat_insights
-    client = rhel_insights_vm
-
-    # Set up the CVE by downgrading to a vulnerable package version
-    assert (
-        client.execute(
-            "find /etc/yum.repos.d/ -type f | grep -vF redhat.repo | xargs -I '{}' rm '{}'"
-        ).status
-        == 0
-    )
-    assert client.execute('dnf -y update').status == 0
-    assert client.execute(f'dnf downgrade -y {GLIBC_RPM}').status == 0
 
     with satellite.ui_session() as session:
         session.organization.select(org_name=rhcloud_manifest_org.name)