Make status and authorId optionable.

Author: jerowork

src/Domain/Blog/BlogRepository.php

@@ -14,8 +14,8 @@ interface BlogRepository
     public function getById(string $blogId): Blog;
 
     public function getBlogs(
-        BlogStatus $status,
-        string $authorId,
+        ?BlogStatus $status,
+        ?string $authorId,
         ?int $first,
         ?string $afterCursor,
         ?int $last,

src/Infrastructure/Api/Http/GraphQL/Resolver/Query/BlogsQuery.php

@@ -25,34 +25,32 @@ public function __construct(
     #[Query(type: new ConnectionType(BlogType::class))]
     public function blogs(
         EdgeArgs $edgeArgs,
-        BlogStatusType $status,
+        ?BlogStatusType $status,
         #[Arg(description: 'The author identifier')]
-        string $authorId,
+        ?string $authorId,
     ): Connection {
         $blogs = $this->blogRepository->getBlogs(
-            BlogStatus::from($status->value),
+            $status !== null ? BlogStatus::from($status->value) : null,
             $authorId,
             $edgeArgs->first,
             $edgeArgs->after,
             $edgeArgs->last,
             $edgeArgs->before,
         );
 
-        $limit = $edgeArgs->last !== null & $edgeArgs->before !== null ? $edgeArgs->last : $edgeArgs->first;
-
         $hasPreviousPage = $this->blogRepository->getBlogs(
-            BlogStatus::from($status->value),
+            $status !== null ? BlogStatus::from($status->value) : null,
             $authorId,
             null,
             null,
-            $limit,
+            $edgeArgs->last ?? $edgeArgs->first,
             $blogs->first()?->id,
         )->blogs !== [];
 
         $hasNextPage = $this->blogRepository->getBlogs(
-            BlogStatus::from($status->value),
+            $status !== null ? BlogStatus::from($status->value) : null,
             $authorId,
-            $limit,
+            $edgeArgs->last ?? $edgeArgs->first,
             $blogs->last()?->id,
             null,
             null,

src/Infrastructure/Persistence/Blog/SQLite/SQLiteBlogRepository.php

@@ -59,73 +59,90 @@ public function getById(string $blogId): Blog
     }
 
     public function getBlogs(
-        BlogStatus $status,
-        string $authorId,
+        ?BlogStatus $status,
+        ?string $authorId,
         ?int $first,
         ?string $afterCursor,
         ?int $last,
         ?string $beforeCursor,
     ): Blogs {
+        if ($first !== null && $last !== null) {
+            throw new RuntimeException('Cannot use both first and last');
+        }
+
         $sqlite = $this->sqliteFactory->create();
-        $direction = $last !== null && $beforeCursor !== null ? self::DIRECTION_BACKWARD : self::DIRECTION_FORWARD;
 
-        if ($direction === self::DIRECTION_BACKWARD) {
+        $direction = $first !== null ? self::DIRECTION_FORWARD : self::DIRECTION_BACKWARD;
+
+        $whereStatements = [];
+        $binds = [];
+
+        if ($status !== null) {
+            $whereStatements[] = 'status = :status';
+            $binds['status'] = $status->value;
+        }
+
+        if ($authorId !== null) {
+            $whereStatements[] = 'author_id = :author_id';
+            $binds['author_id'] = $authorId;
+        }
+
+        $limit = '';
+
+        if ($first !== null) {
+            $limit = 'LIMIT :limit';
+            $binds['limit'] = $first;
+        } elseif ($last !== null) {
+            $limit = 'LIMIT :limit';
+            $binds['limit'] = $last;
+        }
+
+        if ($afterCursor !== null) {
+            $whereStatements[] = 'id < :after_cursor';
+            $binds['after_cursor'] = $afterCursor;
+        }
+
+        if ($beforeCursor !== null) {
+            $whereStatements[] = 'id > :before_cursor';
+            $binds['before_cursor'] = $beforeCursor;
+        }
+
+        $where = '';
+
+        if ($whereStatements !== []) {
+            $where = sprintf('WHERE %s', implode(' AND ', $whereStatements));
+        }
+
+        if ($direction === self::DIRECTION_FORWARD) {
+            $statement = $sqlite->prepare(
+                <<<SQL
+                    SELECT * 
+                    FROM blog 
+                    {$where}
+                    ORDER BY id DESC
+                    {$limit}
+                    SQL
+            );
+        } else {
             $statement = $sqlite->prepare(
-                <<<'SQL'
+                <<<SQL
                     SELECT * FROM (
                         SELECT * 
                         FROM blog 
-                        WHERE status = :status
-                        AND author_id = :author_id
-                        AND id > :cursor
+                        {$where}
                         ORDER BY id ASC
-                        LIMIT :limit
+                        {$limit}
                     ) ORDER BY id DESC
                     SQL
             );
-        } else {
-            if ($afterCursor === null) {
-                $statement = $sqlite->prepare(
-                    <<<'SQL'
-                        SELECT * 
-                        FROM blog 
-                        WHERE status = :status
-                        AND author_id = :author_id
-                        ORDER BY id DESC
-                        LIMIT :limit
-                        SQL
-                );
-            } else {
-                $statement = $sqlite->prepare(
-                    <<<'SQL'
-                        SELECT * 
-                        FROM blog 
-                        WHERE status = :status
-                        AND author_id = :author_id
-                        AND id < :cursor
-                        ORDER BY id DESC
-                        LIMIT :limit
-                        SQL
-                );
-            }
         }
 
         if ($statement === false) {
             throw new RuntimeException('Failed to prepare statement');
         }
 
-        $statement->bindValue('status', $status->value);
-        $statement->bindValue('author_id', $authorId);
-
-        if ($direction === self::DIRECTION_BACKWARD) {
-            $statement->bindValue('cursor', $beforeCursor);
-            $statement->bindValue('limit', $last);
-        } else {
-            if ($afterCursor !== null) {
-                $statement->bindValue('cursor', $afterCursor);
-            }
-
-            $statement->bindValue('limit', $first);
+        foreach ($binds as $key => $value) {
+            $statement->bindValue($key, $value);
         }
 
         $result = $statement->execute();