Drop PHP8.4 property hooks on Attribute interface

jerowork · jerowork · commit b38ee1e7984e · 2025-01-03T15:49:07.000+01:00
diff --git a/src/Attribute/Arg.php b/src/Attribute/Arg.php
@@ -13,4 +13,14 @@ public function __construct(
         public ?string $name = null,
         public ?string $description = null,
     ) {}
+
+    public function getName(): ?string
+    {
+        return $this->name;
+    }
+
+    public function getDescription(): ?string
+    {
+        return $this->description;
+    }
 }
diff --git a/src/Attribute/Enum.php b/src/Attribute/Enum.php
@@ -13,4 +13,14 @@ public function __construct(
         public ?string $name = null,
         public ?string $description = null,
     ) {}
+
+    public function getName(): ?string
+    {
+        return $this->name;
+    }
+
+    public function getDescription(): ?string
+    {
+        return $this->description;
+    }
 }
diff --git a/src/Attribute/Field.php b/src/Attribute/Field.php
@@ -14,4 +14,14 @@ public function __construct(
         public ?string $description = null,
         public ?string $type = null,
     ) {}
+
+    public function getName(): ?string
+    {
+        return $this->name;
+    }
+
+    public function getDescription(): ?string
+    {
+        return $this->description;
+    }
 }
diff --git a/src/Attribute/GraphQLAttribute.php b/src/Attribute/GraphQLAttribute.php
@@ -6,10 +6,7 @@
 
 interface GraphQLAttribute
 {
-    public ?string $name {
-        get;
-    }
-    public ?string $description {
-        get;
-    }
+    public function getName(): ?string;
+
+    public function getDescription(): ?string;
 }
diff --git a/src/Attribute/InputType.php b/src/Attribute/InputType.php
@@ -13,4 +13,14 @@ public function __construct(
         public ?string $name = null,
         public ?string $description = null,
     ) {}
+
+    public function getName(): ?string
+    {
+        return $this->name;
+    }
+
+    public function getDescription(): ?string
+    {
+        return $this->description;
+    }
 }
diff --git a/src/Attribute/Mutation.php b/src/Attribute/Mutation.php
@@ -13,4 +13,14 @@ public function __construct(
         public ?string $name = null,
         public ?string $description = null,
     ) {}
+
+    public function getName(): ?string
+    {
+        return $this->name;
+    }
+
+    public function getDescription(): ?string
+    {
+        return $this->description;
+    }
 }
diff --git a/src/Attribute/Query.php b/src/Attribute/Query.php
@@ -13,4 +13,14 @@ public function __construct(
         public ?string $name = null,
         public ?string $description = null,
     ) {}
+
+    public function getName(): ?string
+    {
+        return $this->name;
+    }
+
+    public function getDescription(): ?string
+    {
+        return $this->description;
+    }
 }
diff --git a/src/Attribute/Type.php b/src/Attribute/Type.php
@@ -13,4 +13,14 @@ public function __construct(
         public ?string $name = null,
         public ?string $description = null,
     ) {}
+
+    public function getName(): ?string
+    {
+        return $this->name;
+    }
+
+    public function getDescription(): ?string
+    {
+        return $this->description;
+    }
 }
diff --git a/src/Parser/NodeParser/EnumNodeParser.php b/src/Parser/NodeParser/EnumNodeParser.php
@@ -39,7 +39,7 @@ public function parse(ReflectionClass $class): Node
         return new EnumNode(
             $className,
             $this->retrieveNameForType($class, $attribute),
-            $attribute->description,
+            $attribute->getDescription(),
             array_map(fn($case) => (string) $case->value, $className::cases()),
         );
     }
diff --git a/src/Parser/NodeParser/InputTypeNodeParser.php b/src/Parser/NodeParser/InputTypeNodeParser.php
@@ -34,7 +34,7 @@ public function parse(ReflectionClass $class): Node
         return new InputTypeNode(
             $class->getName(),
             $this->retrieveNameForType($class, $attribute),
-            $attribute->description,
+            $attribute->getDescription(),
             $this->classFieldNodesParser->parse($class),
         );
     }
diff --git a/src/Parser/NodeParser/MutationNodeParser.php b/src/Parser/NodeParser/MutationNodeParser.php
@@ -52,7 +52,7 @@ public function parse(ReflectionClass $class): Node
         return new MutationNode(
             $class->getName(),
             $this->retrieveNameForResolver($class, $attribute, self::RESOLVER_SUFFIX),
-            $attribute->description,
+            $attribute->getDescription(),
             $this->methodArgNodesParser->parse($method),
             $this->getTypeId($returnType),
             $this->getType($returnType),
diff --git a/src/Parser/NodeParser/QueryNodeParser.php b/src/Parser/NodeParser/QueryNodeParser.php
@@ -52,7 +52,7 @@ public function parse(ReflectionClass $class): Node
         return new QueryNode(
             $class->getName(),
             $this->retrieveNameForResolver($class, $attribute, self::RESOLVER_SUFFIX),
-            $attribute->description,
+            $attribute->getDescription(),
             $this->methodArgNodesParser->parse($method),
             $this->getTypeId($returnType),
             $this->getType($returnType),
diff --git a/src/Parser/NodeParser/RetrieveNameForFieldTrait.php b/src/Parser/NodeParser/RetrieveNameForFieldTrait.php
@@ -13,7 +13,7 @@ trait RetrieveNameForFieldTrait
 
     public function retrieveNameForField(ReflectionMethod $method, GraphQLAttribute $attribute): string
     {
-        return $attribute->name ?? $this->retrieveFromMethod($method);
+        return $attribute->getName() ?? $this->retrieveFromMethod($method);
     }
 
     private function retrieveFromMethod(ReflectionMethod $method): string
diff --git a/src/Parser/NodeParser/RetrieveNameForResolverTrait.php b/src/Parser/NodeParser/RetrieveNameForResolverTrait.php
@@ -18,7 +18,7 @@ trait RetrieveNameForResolverTrait
      */
     public function retrieveNameForResolver(ReflectionClass $class, GraphQLAttribute $attribute, string $suffix): string
     {
-        $name = $attribute->name ?? $this->retrieveNameFromClass($class, $suffix);
+        $name = $attribute->getName() ?? $this->retrieveNameFromClass($class, $suffix);
 
         if (preg_match(self::VALID_REGEX, $name) !== 1) {
             throw ParseException::invalidNameForResolver($name);
diff --git a/src/Parser/NodeParser/RetrieveNameForTypeTrait.php b/src/Parser/NodeParser/RetrieveNameForTypeTrait.php
@@ -19,7 +19,7 @@ trait RetrieveNameForTypeTrait
      */
     public function retrieveNameForType(ReflectionClass $class, GraphQLAttribute $attribute): string
     {
-        $name = $attribute->name ?? $this->retrieveNameFromClass($class);
+        $name = $attribute->getName() ?? $this->retrieveNameFromClass($class);
 
         if (preg_match(self::VALID_REGEX, $name) !== 1) {
             throw ParseException::invalidNameForType($name);
diff --git a/src/Parser/NodeParser/TypeNodeParser.php b/src/Parser/NodeParser/TypeNodeParser.php
@@ -34,7 +34,7 @@ public function parse(ReflectionClass $class): Node
         return new TypeNode(
             $class->getName(),
             $this->retrieveNameForType($class, $attribute),
-            $attribute->description,
+            $attribute->getDescription(),
             $this->classFieldNodesParser->parse($class),
         );
     }

Original file line number	Diff line number	Diff line change
`@@ -6,10 +6,7 @@`
`6`	`6`
`7`	`7`	`interface GraphQLAttribute`
`8`	`8`	`{`
`9`		`- public ?string $name {`
`10`		`- get;`
`11`		`- }`
`12`		`- public ?string $description {`
`13`		`- get;`
`14`		`- }`
	`9`	`+ public function getName(): ?string;`
	`10`	`+`
	`11`	`+ public function getDescription(): ?string;`
`15`	`12`	`}`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ public function parse(ReflectionClass $class): Node`
`39`	`39`	`return new EnumNode(`
`40`	`40`	`$className,`
`41`	`41`	`$this->retrieveNameForType($class, $attribute),`
`42`		`- $attribute->description,`
	`42`	`+ $attribute->getDescription(),`
`43`	`43`	`array_map(fn($case) => (string) $case->value, $className::cases()),`
`44`	`44`	`);`
`45`	`45`	`}`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ public function parse(ReflectionClass $class): Node`
`34`	`34`	`return new InputTypeNode(`
`35`	`35`	`$class->getName(),`
`36`	`36`	`$this->retrieveNameForType($class, $attribute),`
`37`		`- $attribute->description,`
	`37`	`+ $attribute->getDescription(),`
`38`	`38`	`$this->classFieldNodesParser->parse($class),`
`39`	`39`	`);`
`40`	`40`	`}`