Change the error messages to error object. (#34)

IoT.js-Debug-DCO-1.0-Signed-off-by: Imre Kiss [email protected]

Author: knightburton

src/IotjsDebugger.ts

@@ -224,7 +224,7 @@ class IotjsDebugSession extends DebugSession {
       .then(() => {
         this.sendResponse(response);
       })
-      .catch(error => this.sendErrorResponse(response, 0, error));
+      .catch(error => this.sendErrorResponse(response, 0, (<Error>error).message));
   }
 
   protected nextRequest(response: DebugProtocol.NextResponse, args: DebugProtocol.NextArguments): void {
@@ -234,7 +234,7 @@ class IotjsDebugSession extends DebugSession {
     .then(() => {
       this.sendResponse(response);
     })
-    .catch(error => this.sendErrorResponse(response, 0, error));
+    .catch(error => this.sendErrorResponse(response, 0, (<Error>error).message));
   }
 
   protected stepInRequest(response: DebugProtocol.StepInResponse, args: DebugProtocol.StepInArguments): void {
@@ -244,7 +244,7 @@ class IotjsDebugSession extends DebugSession {
       .then(() => {
         this.sendResponse(response);
       })
-      .catch(error => this.sendErrorResponse(response, 0, error));
+      .catch(error => this.sendErrorResponse(response, 0, (<Error>error).message));
   }
 
   protected stepOutRequest(response: DebugProtocol.StepOutResponse, args: DebugProtocol.StepOutArguments): void {
@@ -254,7 +254,7 @@ class IotjsDebugSession extends DebugSession {
     .then(() => {
       this.sendResponse(response);
     })
-    .catch(error => this.sendErrorResponse(response, 0, error));
+    .catch(error => this.sendErrorResponse(response, 0, (<Error>error).message));
   }
 
   protected pauseRequest(response: DebugProtocol.PauseResponse, args: DebugProtocol.PauseArguments): void {
@@ -264,7 +264,7 @@ class IotjsDebugSession extends DebugSession {
     .then(() => {
       this.sendResponse(response);
     })
-    .catch(error => this.sendErrorResponse(response, 0, error));
+    .catch(error => this.sendErrorResponse(response, 0, (<Error>error).message));
   }
 
   protected async setBreakPointsRequest(
@@ -311,8 +311,8 @@ class IotjsDebugSession extends DebugSession {
 
       response.body = { breakpoints: [...persistingBreakpoints, ...newBreakpoints] };
     } catch (error) {
-      this.log(error.message);
-      this.sendErrorResponse(response, error.message);
+      this.log(error);
+      this.sendErrorResponse(response, 0, (<Error>error).message);
       return;
     }
 
@@ -333,7 +333,7 @@ class IotjsDebugSession extends DebugSession {
 
         this.sendResponse(response);
       })
-      .catch(error => this.sendErrorResponse(response, 0, error));
+      .catch(error => this.sendErrorResponse(response, 0, (<Error>error).message));
   }
 
   protected stackTraceRequest(
@@ -359,7 +359,7 @@ class IotjsDebugSession extends DebugSession {
 
         this.sendResponse(response);
       })
-      .catch(error => this.sendErrorResponse(response, 0, error));
+      .catch(error => this.sendErrorResponse(response, 0, (<Error>error).message));
   }
 
   protected customRequest(command: string, response: DebugProtocol.Response, args: any): void {
@@ -377,7 +377,7 @@ class IotjsDebugSession extends DebugSession {
           .catch(error => {
             this.log(error);
             this._sourceSendingOptions.state = SOURCE_SENDING_STATES.NOP;
-            this.sendErrorResponse(response, 0, error, null, ErrorDestination.User);
+            this.sendErrorResponse(response, 0, (<Error>error).message, null, ErrorDestination.User);
           });
         return;
       }

src/JerryProtocolHandler.ts

@@ -211,7 +211,7 @@ export class JerryDebugProtocolHandler {
 
   public pause(): Promise<any> {
     if (this.lastBreakpointHit) {
-      return Promise.reject('attempted pause while at breakpoint');
+      return Promise.reject(new Error('attempted pause while at breakpoint'));
     }
     return this.sendSimpleRequest(encodeMessage(this.byteConfig, 'B', [SP.CLIENT.JERRY_DEBUGGER_STOP]));
   }
@@ -626,7 +626,7 @@ export class JerryDebugProtocolHandler {
 
   public evaluate(expression: string): Promise<any> {
     if (!this.lastBreakpointHit) {
-      return Promise.reject('attempted eval while not at breakpoint');
+      return Promise.reject(new Error('attempted eval while not at breakpoint'));
     }
 
     this.evalsPending++;
@@ -697,7 +697,7 @@ export class JerryDebugProtocolHandler {
 
   public requestBacktrace(): Promise<any> {
     if (!this.lastBreakpointHit) {
-      return Promise.reject('backtrace not allowed while app running');
+      return Promise.reject(new Error('backtrace not allowed while app running'));
     }
     return this.sendRequest(encodeMessage(this.byteConfig, 'BI', [SP.CLIENT.JERRY_DEBUGGER_GET_BACKTRACE, 0]));
   }
@@ -717,7 +717,7 @@ export class JerryDebugProtocolHandler {
 
   private resumeExec(code: number): Promise<any> {
     if (!this.lastBreakpointHit) {
-      return Promise.reject('attempted resume while not at breakpoint');
+      return Promise.reject(new Error('attempted resume while not at breakpoint'));
     }
 
     this.lastBreakpointHit = undefined;
@@ -732,7 +732,7 @@ export class JerryDebugProtocolHandler {
 
   public sendClientSource(fileName: string, fileSourceCode: string): Promise<any> {
     if (!this.waitForSourceEnabled) {
-      return Promise.reject('wait-for-source not enabled');
+      return Promise.reject(new Error('wait-for-source not enabled'));
     }
 
     this.waitForSourceEnabled = false;
@@ -762,7 +762,7 @@ export class JerryDebugProtocolHandler {
     const validCodes: number[] = [SP.CLIENT.JERRY_DEBUGGER_NO_MORE_SOURCES, SP.CLIENT.JERRY_DEBUGGER_CONTEXT_RESET];
 
     if (validCodes.indexOf(code) === -1) {
-      return Promise.reject('Invalid source sending control code.');
+      return Promise.reject(new Error('Invalid source sending control code.'));
     }
 
     return this.sendSimpleRequest(encodeMessage(this.byteConfig, 'B', [code]));
@@ -782,7 +782,7 @@ export class JerryDebugProtocolHandler {
       this.requestQueue = [...this.requestQueue, request];
     } else {
       if (!this.submitRequest(request)) {
-        return Promise.reject('Failed to submit request.');
+        return Promise.reject(new Error('Failed to submit request.'));
       }
     }
 
@@ -793,7 +793,7 @@ export class JerryDebugProtocolHandler {
     const request = new PendingRequest(data);
 
     if (!this.submitRequest(request, true)) {
-      return Promise.reject('Failed to submit request.');
+      return Promise.reject(new Error('Failed to submit request.'));
     }
 
     return Promise.resolve();

src/test/JerryProtocolHandler.test.ts

@@ -545,7 +545,7 @@ suite('JerryProtocolHandler', () => {
             const handler = new JerryDebugProtocolHandler({});
             await handler.requestBacktrace()
                 .catch(error => {
-                    assert.strictEqual(error, 'backtrace not allowed while app running');
+                    assert.strictEqual((<Error>error).message, 'backtrace not allowed while app running');
                 });
         });