Skip to content

Commit e053042

Browse files
Sanggyu Leeyichoi
authored andcommitted
Skip read-only file system test on NuttX (#988)
NuttX does not support read-only attributes in fat mounted file system. Therefore, run read-only test on linux only. IoT.js-DCO-1.0-Signed-off-by: Sanggyu Lee [email protected]
1 parent 62b04dd commit e053042

File tree

2 files changed

+21
-17
lines changed

2 files changed

+21
-17
lines changed

test/run_pass/test_fs_mkdir_rmdir.js

Lines changed: 20 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -50,32 +50,36 @@ function unlink(path) {
5050

5151
var root2 = process.cwd() + "/resources/test_dir2";
5252

53-
fs.mkdir(root2, 777, function(err){
53+
fs.mkdir(root2, 777, function(err) {
5454
assert.equal(err, null);
5555
assert.equal(fs.existsSync(root2), true);
5656

5757
fs.rmdir(root2, function(){
5858
assert.equal(fs.existsSync(root2), false);
5959
});
6060

61-
// Try to create a folder in a read-only directory.
62-
fs.mkdir(root, '0444', function(err) {
63-
assert.equal(fs.existsSync(root), true);
61+
// Run read-only directory test only on linux
62+
// NuttX does not support read-only attribute.
63+
if (process.platform === 'linux') {
64+
// Try to create a folder in a read-only directory.
65+
fs.mkdir(root, '0444', function(err) {
66+
assert.equal(fs.existsSync(root), true);
6467

65-
var dirname = root + "/permission_test";
66-
try {
67-
fs.mkdirSync(dirname);
68-
assert.assert(false);
69-
} catch (e) {
70-
assert.equal(e instanceof Error, true);
71-
assert.equal(e instanceof assert.AssertionError, false);
72-
}
68+
var dirname = root + "/permission_test";
69+
try {
70+
fs.mkdirSync(dirname);
71+
assert.assert(false);
72+
} catch (e) {
73+
assert.equal(e instanceof Error, true);
74+
assert.equal(e instanceof assert.AssertionError, false);
75+
}
7376

74-
assert.equal(fs.existsSync(dirname), false);
75-
fs.rmdir(root, function() {
76-
assert.equal(fs.existsSync(root), false);
77+
assert.equal(fs.existsSync(dirname), false);
78+
fs.rmdir(root, function() {
79+
assert.equal(fs.existsSync(root), false);
80+
});
7781
});
78-
});
82+
}
7983
});
8084
});
8185
}

test/testsets.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
{ "name": "test_fs_exists_sync.js" },
2626
{ "name": "test_fs_fstat.js", "skip": ["nuttx"], "reason": "not implemented for nuttx" },
2727
{ "name": "test_fs_fstat_sync.js", "skip": ["nuttx"], "reason": "not implemented for nuttx" },
28-
{ "name": "test_fs_mkdir_rmdir.js", "skip": ["nuttx"], "reason": "not implemented for nuttx" },
28+
{ "name": "test_fs_mkdir_rmdir.js", "skip": ["nuttx"], "reason": "implemented, run manually in default configuration" },
2929
{ "name": "test_fs_open_close.js", "skip": ["nuttx"], "reason": "not implemented for nuttx" },
3030
{ "name": "test_fs_readdir.js", "skip": ["nuttx"], "reason": "not implemented for nuttx" },
3131
{ "name": "test_fs_readfile.js" },

0 commit comments

Comments
 (0)