Skip to content

Commit f2bae40

Browse files
committed
Remove unnecessary empty value check code
Related PR: #1276 Since RegExp.protytype.exec doesn't change the ret_value any more when filling the result array, its empty value check code can be removed. JerryScript-DCO-1.0-Signed-off-by: Youngil Choi [email protected]
1 parent be1029d commit f2bae40

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

jerry-core/ecma/operations/ecma-regexp-object.c

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1410,7 +1410,7 @@ ecma_regexp_exec_helper (ecma_value_t regexp_value, /**< RegExp object */
14101410
re_set_result_array_properties (result_array_obj_p, input_str_p, re_ctx.num_of_captures / 2, index);
14111411
ecma_deref_ecma_string (input_str_p);
14121412

1413-
for (uint32_t i = 0; ecma_is_value_empty (ret_value) && i < re_ctx.num_of_captures; i += 2)
1413+
for (uint32_t i = 0; i < re_ctx.num_of_captures; i += 2)
14141414
{
14151415
ecma_string_t *index_str_p = ecma_new_ecma_string_from_uint32 (i / 2);
14161416
ecma_value_t capture_value = ecma_make_simple_value (ECMA_SIMPLE_VALUE_UNDEFINED);
@@ -1444,14 +1444,7 @@ ecma_regexp_exec_helper (ecma_value_t regexp_value, /**< RegExp object */
14441444
ecma_deref_ecma_string (index_str_p);
14451445
}
14461446

1447-
if (ecma_is_value_empty (ret_value))
1448-
{
1449-
ret_value = result_array;
1450-
}
1451-
else
1452-
{
1453-
ecma_deref_object (result_array_obj_p);
1454-
}
1447+
ret_value = result_array;
14551448
}
14561449
else
14571450
{

0 commit comments

Comments
 (0)