Skip to content

Conversation

@gortavoher
Copy link
Contributor

  • update keywords to include recaptcha for enhanced discoverability
  • add recaptcha feature to dependencies for expanded captcha options

- update keywords to include recaptcha for enhanced discoverability
- add recaptcha feature to dependencies for expanded captcha options
@gortavoher gortavoher requested a review from jerusdp as a code owner July 1, 2025 12:00
@gortavoher gortavoher self-assigned this Jul 1, 2025
jerus-bot and others added 10 commits July 1, 2025 12:08
- include recaptcha feature in captval dependency for enhanced functionality
  - include recaptcha pass tests to ensure comprehensive test coverage

♻️ refactor(captval): remove hex dependency and related features
  - eliminate hex dependency from Cargo.toml and Cargo.lock
  - remove ext feature and associated code
  - streamline the Secret parsing logic

🌐 i18n(recaptcha): add recaptcha feature and validation types
  - introduce recaptcha support with secret, sitekey, and token validation
  - define VERIFY_URL for Google reCAPTCHA

✅ test(recaptcha): implement recaptcha integration tests
  - add integration tests for recaptcha validation
  - create helper module for generating test data
- set cargo_all_features to false for required, optional, and common builds
- enhance build configuration consistency across different workflows
- reorder imports for consistency
- enhance readability with multiline formatting for tracing attributes
- add noDefaultFeatures and features settings for rust-analyzer in vscode settings.json

📦 build(dependencies): add hex dependency

- add hex to Cargo.lock and Cargo.toml for dependency management

♻️ refactor(client): improve verification URL selection

- replace direct URL parse with default_verify_url function
- update documentation for Client struct and its methods

♻️ refactor(form): relocate form module

- move form module to a more logical location in the directory structure

🔥 refactor(hcaptcha): remove unused modules

- delete sitekey.rs, token.rs, and secret.rs from hcaptcha directory

♻️ refactor(secret): consolidate secret module

- merge secret.rs files from hcaptcha and recaptcha into a single module

✅ test(secret): add feature-specific tests for secret parsing

- add hcaptcha and recaptcha specific tests for Secret parsing to ensure feature compatibility

✅ test(sitekey): add feature-specific tests for sitekey parsing

- add hcaptcha and recaptcha specific tests for Sitekey parsing

✅ test(token): add feature-specific tests for token parsing

- add hcaptcha and recaptcha specific tests for Token parsing to ensure feature compatibility
- implement feature-specific sitekey validation for hcaptcha and recaptcha
- refactor invalid_sitekey function into separate functions for each feature
- update tests to accommodate changes in sitekey validation logic
- delete `test_invalid_secret_v1.rs` and `test_invalid_secret_v2.rs` files
- remove tests related to invalid secret scenarios for hcaptcha validation
- remove unnecessary semicolon in sitekey validation
- update tracing instrumentation to skip unused parameter
- modify feature flags to use nativetls-backend
- adjust existing flags for better compatibility and testing
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
19.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants