-
-
Notifications
You must be signed in to change notification settings - Fork 0
🔧 chore(cargo): add recaptcha support to captval #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gortavoher
wants to merge
11
commits into
main
Choose a base branch
from
feature/recaptcha-support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gortavoher
commented
Jul 1, 2025
- update keywords to include recaptcha for enhanced discoverability
- add recaptcha feature to dependencies for expanded captcha options
- update keywords to include recaptcha for enhanced discoverability - add recaptcha feature to dependencies for expanded captcha options
- include recaptcha feature in captval dependency for enhanced functionality
- include recaptcha pass tests to ensure comprehensive test coverage ♻️ refactor(captval): remove hex dependency and related features - eliminate hex dependency from Cargo.toml and Cargo.lock - remove ext feature and associated code - streamline the Secret parsing logic 🌐 i18n(recaptcha): add recaptcha feature and validation types - introduce recaptcha support with secret, sitekey, and token validation - define VERIFY_URL for Google reCAPTCHA ✅ test(recaptcha): implement recaptcha integration tests - add integration tests for recaptcha validation - create helper module for generating test data
- set cargo_all_features to false for required, optional, and common builds - enhance build configuration consistency across different workflows
- reorder imports for consistency - enhance readability with multiline formatting for tracing attributes
- add noDefaultFeatures and features settings for rust-analyzer in vscode settings.json 📦 build(dependencies): add hex dependency - add hex to Cargo.lock and Cargo.toml for dependency management ♻️ refactor(client): improve verification URL selection - replace direct URL parse with default_verify_url function - update documentation for Client struct and its methods ♻️ refactor(form): relocate form module - move form module to a more logical location in the directory structure 🔥 refactor(hcaptcha): remove unused modules - delete sitekey.rs, token.rs, and secret.rs from hcaptcha directory ♻️ refactor(secret): consolidate secret module - merge secret.rs files from hcaptcha and recaptcha into a single module ✅ test(secret): add feature-specific tests for secret parsing - add hcaptcha and recaptcha specific tests for Secret parsing to ensure feature compatibility ✅ test(sitekey): add feature-specific tests for sitekey parsing - add hcaptcha and recaptcha specific tests for Sitekey parsing ✅ test(token): add feature-specific tests for token parsing - add hcaptcha and recaptcha specific tests for Token parsing to ensure feature compatibility
- implement feature-specific sitekey validation for hcaptcha and recaptcha - refactor invalid_sitekey function into separate functions for each feature - update tests to accommodate changes in sitekey validation logic
- delete `test_invalid_secret_v1.rs` and `test_invalid_secret_v2.rs` files - remove tests related to invalid secret scenarios for hcaptcha validation
- remove unnecessary semicolon in sitekey validation - update tracing instrumentation to skip unused parameter
- modify feature flags to use nativetls-backend - adjust existing flags for better compatibility and testing
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

