Skip to content

Commit c21fc7a

Browse files
gortavoherclaude
andcommitted
fix: remove unnecessary select_rust_version for stable toolchain
Per review feedback, select_rust_version is only needed when there's potential for MSRV fallback. Using it for the stable toolchain is wasteful since stable is always available. - Remove select_rust_version calls from jobs using cargo +stable - Replace ${RUST_VERSION} with hardcoded +stable in those jobs 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]> Signed-off-by: Jeremiah Russell <[email protected]>
1 parent 482e106 commit c21fc7a

File tree

1 file changed

+7
-15
lines changed

1 file changed

+7
-15
lines changed

.circleci/config.yml

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,7 @@ jobs:
6767
name: toolkit/rust_wasi_rolling
6868
steps:
6969
- checkout
70-
- toolkit/select_rust_version:
71-
rust_version: stable
72-
- run: cargo "+${RUST_VERSION}" --version
70+
- run: cargo +stable --version
7371
- set_repro_env
7472
- run:
7573
name: Package crates
@@ -117,26 +115,22 @@ jobs:
117115
name: toolkit/rust_wasi_rolling
118116
steps:
119117
- checkout
120-
- toolkit/select_rust_version:
121-
rust_version: stable
122-
- run: cargo "+${RUST_VERSION}" --version
118+
- run: cargo +stable --version
123119
- set_repro_env
124120
- run:
125121
name: Running test suite <<parameters.test-suite>>
126-
command: "cargo +${RUST_VERSION} test -p <<parameters.test-suite>> --test compiletest"
122+
command: "cargo +stable test -p <<parameters.test-suite>> --test compiletest"
127123

128124
doc_tests:
129125
executor:
130126
name: toolkit/rust_wasi_rolling
131127
steps:
132128
- checkout
133-
- toolkit/select_rust_version:
134-
rust_version: stable
135-
- run: cargo "+${RUST_VERSION}" --version
129+
- run: cargo +stable --version
136130
- set_repro_env
137131
- run:
138132
name: Run doctests for core crate
139-
command: cargo "+${RUST_VERSION}" test -p hcaptcha --doc
133+
command: cargo +stable test -p hcaptcha --doc
140134

141135
run_test_program:
142136
parameters:
@@ -150,9 +144,7 @@ jobs:
150144
name: toolkit/rust_wasi_rolling
151145
steps:
152146
- checkout
153-
- toolkit/select_rust_version:
154-
rust_version: stable
155-
- run: cargo "+${RUST_VERSION}" --version
147+
- run: cargo +stable --version
156148
- set_repro_env
157149
- restore_cache:
158150
key: << parameters.cache_version >>-{{ .Branch }}-{{ checksum "Cargo.lock" }}
@@ -161,7 +153,7 @@ jobs:
161153
command: |
162154
set -ex
163155
if [ ! -f bin/hcaptcha-cli ]; then
164-
cargo "+${RUST_VERSION}" build \
156+
cargo +stable build \
165157
--release \
166158
--package hcaptcha-cli
167159
mkdir -p bin

0 commit comments

Comments
 (0)