Skip to content

Commit 0c0c32a

Browse files
committed
Show "Close/Cancel: <esc>" for menus like we do for confirmations
For many menus, just "Close" is fine, but some menus act more like confirmations (e.g. the menu that appears when you cherry-pick and get conflicts); in this case, it's good to make it more obvious that hitting esc cancels the whole thing.
1 parent aeff986 commit 0c0c32a

File tree

8 files changed

+8
-8
lines changed

8 files changed

+8
-8
lines changed

docs/keybindings/Keybindings_en.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -256,7 +256,7 @@ _Legend: `<c-b>` means ctrl+b, `<a-b>` means alt+b, `B` means shift+b_
256256
| Key | Action | Info |
257257
|-----|--------|-------------|
258258
| `` <enter> `` | Execute | |
259-
| `` <esc> `` | Close | |
259+
| `` <esc> `` | Close/Cancel | |
260260
| `` / `` | Filter the current view by text | |
261261

262262
## Reflog

docs/keybindings/Keybindings_ja.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,7 @@ _凡例:`<c-b>` はctrl+b、`<a-b>` はalt+b、`B` はshift+bを意味
302302
| Key | Action | Info |
303303
|-----|--------|-------------|
304304
| `` <enter> `` | 実行 | |
305-
| `` <esc> `` | 閉じる | |
305+
| `` <esc> `` | 閉じる/キャンセル | |
306306
| `` / `` | 現在のビューをテキストでフィルタリング | |
307307

308308
## リフログ

docs/keybindings/Keybindings_ko.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ _Legend: `<c-b>` means ctrl+b, `<a-b>` means alt+b, `B` means shift+b_
128128
| Key | Action | Info |
129129
|-----|--------|-------------|
130130
| `` <enter> `` | 실행 | |
131-
| `` <esc> `` | 닫기 | |
131+
| `` <esc> `` | 닫기/취소 | |
132132
| `` / `` | Filter the current view by text | |
133133

134134
## 메인 패널 (Merging)

docs/keybindings/Keybindings_pl.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ _Legenda: `<c-b>` oznacza ctrl+b, `<a-b>` oznacza alt+b, `B` oznacza shift+b_
159159
| Key | Action | Info |
160160
|-----|--------|-------------|
161161
| `` <enter> `` | Wykonaj | |
162-
| `` <esc> `` | Zamknij | |
162+
| `` <esc> `` | Zamknij/Anuluj | |
163163
| `` / `` | Filtruj bieżący widok po tekście | |
164164

165165
## Panel główny (normalny)

docs/keybindings/Keybindings_pt.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ _Legend: `<c-b>` means ctrl+b, `<a-b>` means alt+b, `B` means shift+b_
221221
| Key | Action | Info |
222222
|-----|--------|-------------|
223223
| `` <enter> `` | Executar | |
224-
| `` <esc> `` | Fechar | |
224+
| `` <esc> `` | Fechar/Cancelar | |
225225
| `` / `` | Filter the current view by text | |
226226

227227
## Painel Principal (Normal)

docs/keybindings/Keybindings_ru.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ _Связки клавиш_
227227
| Key | Action | Info |
228228
|-----|--------|-------------|
229229
| `` <enter> `` | Выполнить | |
230-
| `` <esc> `` | Закрыть | |
230+
| `` <esc> `` | Закрыть/отменить | |
231231
| `` / `` | Filter the current view by text | |
232232

233233
## Панель Подтверждения

docs/keybindings/Keybindings_zh-TW.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ _說明:`<c-b>` 表示 Ctrl+B、`<a-b>` 表示 Alt+B,`B`表示 Shift+B
119119
| Key | Action | Info |
120120
|-----|--------|-------------|
121121
| `` <enter> `` | 執行 | |
122-
| `` <esc> `` | 關閉 | |
122+
| `` <esc> `` | 關閉/取消 | |
123123
| `` / `` | 搜尋 | |
124124

125125
## 子提交

pkg/gui/controllers/menu_controller.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ func (self *MenuController) GetKeybindings(opts types.KeybindingsOpts) []*types.
4747
{
4848
Key: opts.GetKey(opts.Config.Universal.Return),
4949
Handler: self.close,
50-
Description: self.c.Tr.Close,
50+
Description: self.c.Tr.CloseCancel,
5151
DisplayOnScreen: true,
5252
},
5353
}

0 commit comments

Comments
 (0)