Enable nolintlint linter, and fix warnings

Author: stefanhaller

.golangci.yml

@@ -7,6 +7,7 @@ linters:
     - exhaustive
     - makezero
     - nakedret
+    - nolintlint
     - prealloc
     - thelper
     - tparallel

pkg/gui/controllers/files_controller.go

@@ -18,7 +18,7 @@ import (
 )
 
 type FilesController struct {
-	baseController // nolint: unused
+	baseController
 	*ListControllerTrait[*filetree.FileNode]
 	c *ControllerCommon
 }

pkg/gui/controllers/list_controller_trait.go

@@ -87,7 +87,7 @@ func (self *ListControllerTrait[T]) itemRangeSelected(callbacks ...func([]T, int
 	}
 }
 
-func (self *ListControllerTrait[T]) itemsSelected(callbacks ...func([]T) *types.DisabledReason) func() *types.DisabledReason { //nolint:unused
+func (self *ListControllerTrait[T]) itemsSelected(callbacks ...func([]T) *types.DisabledReason) func() *types.DisabledReason {
 	return func() *types.DisabledReason {
 		items, _, _ := self.getSelectedItems()
 		if len(items) == 0 {

pkg/gui/gui.go

@@ -965,7 +965,7 @@ func (gui *Gui) runSubprocessWithSuspense(subprocess *oscommands.CmdObj) (bool,
 	return true, nil
 }
 
-func (gui *Gui) runSubprocess(cmdObj *oscommands.CmdObj) error { //nolint:unparam
+func (gui *Gui) runSubprocess(cmdObj *oscommands.CmdObj) error {
 	gui.LogCommand(cmdObj.ToString(), true)
 
 	subprocess := cmdObj.GetCmd()

pkg/integration/components/runner.go

@@ -48,7 +48,7 @@ func RunTests(args RunTestArgs) error {
 	}
 
 	for _, test := range args.Tests {
-		args.TestWrapper(test, func() error { //nolint: thelper
+		args.TestWrapper(test, func() error {
 			paths := NewPaths(
 				filepath.Join(testDir, test.Name()),
 			)