Skip to content

Commit 4cfa6e0

Browse files
committed
Modernize benchmarks
See https://go.dev/blog/testing-b-loop
1 parent 14eb4c2 commit 4cfa6e0

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

pkg/config/app_config_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -691,7 +691,7 @@ keybinding:
691691
`)
692692

693693
func BenchmarkMigrationOnLargeConfiguration(b *testing.B) {
694-
for i := 0; i < b.N; i++ {
694+
for b.Loop() {
695695
_, _ = computeMigratedConfig("path doesn't matter", largeConfiguration)
696696
}
697697
}

pkg/gui/presentation/graph/graph_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -548,7 +548,7 @@ func BenchmarkRenderCommitGraph(b *testing.B) {
548548
return authors.AuthorStyle(commit.AuthorName)
549549
}
550550
b.ResetTimer()
551-
for i := 0; i < b.N; i++ {
551+
for b.Loop() {
552552
RenderCommitGraph(commits, "selected", getStyle)
553553
}
554554
}

pkg/utils/formatting_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -253,25 +253,25 @@ func TestRenderDisplayStrings(t *testing.T) {
253253
}
254254

255255
func BenchmarkStringWidthAsciiOriginal(b *testing.B) {
256-
for i := 0; i < b.N; i++ {
256+
for b.Loop() {
257257
runewidth.StringWidth("some ASCII string")
258258
}
259259
}
260260

261261
func BenchmarkStringWidthAsciiOptimized(b *testing.B) {
262-
for i := 0; i < b.N; i++ {
262+
for b.Loop() {
263263
StringWidth("some ASCII string")
264264
}
265265
}
266266

267267
func BenchmarkStringWidthNonAsciiOriginal(b *testing.B) {
268-
for i := 0; i < b.N; i++ {
268+
for b.Loop() {
269269
runewidth.StringWidth("some non-ASCII string 🍉")
270270
}
271271
}
272272

273273
func BenchmarkStringWidthNonAsciiOptimized(b *testing.B) {
274-
for i := 0; i < b.N; i++ {
274+
for b.Loop() {
275275
StringWidth("some non-ASCII string 🍉")
276276
}
277277
}

0 commit comments

Comments
 (0)