Skip to content

Commit 9e64f7d

Browse files
committed
Bump gocui and adapt lazygit code
Adaptions are for this gocui commit: Cleanup: remove Is* error functions - Use errors.Is instead of quality comparisons. This is better because it matches wrapped errors as well, which we will need later in this branch. - Inline the errors.Is calls at the call sites. This is idiomatic go, we don't need helper functions for this. See https://go.dev/blog/go1.13-errors for more about this.
1 parent ac0c3db commit 9e64f7d

File tree

7 files changed

+27
-35
lines changed

7 files changed

+27
-35
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ require (
1515
github.com/integrii/flaggy v1.4.0
1616
github.com/jesseduffield/generics v0.0.0-20250517122708-b0b4a53a6f5c
1717
github.com/jesseduffield/go-git/v5 v5.14.1-0.20250407170251-e1a013310ccd
18-
github.com/jesseduffield/gocui v0.3.1-0.20250529123049-319bd37ff248
18+
github.com/jesseduffield/gocui v0.3.1-0.20250605111917-fc5387961412
1919
github.com/jesseduffield/kill v0.0.0-20250101124109-e216ddbe133a
2020
github.com/jesseduffield/lazycore v0.0.0-20221012050358-03d2e40243c5
2121
github.com/jesseduffield/minimal/gitignore v0.3.3-0.20211018110810-9cde264e6b1e

go.sum

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -194,8 +194,8 @@ github.com/jesseduffield/generics v0.0.0-20250517122708-b0b4a53a6f5c h1:tC2Paiis
194194
github.com/jesseduffield/generics v0.0.0-20250517122708-b0b4a53a6f5c/go.mod h1:F2fEBk0ddf6ixrBrJjY7phfQ3hL9rXG0uSjvwYe50bE=
195195
github.com/jesseduffield/go-git/v5 v5.14.1-0.20250407170251-e1a013310ccd h1:ViKj6qth8FgcIWizn9KiACWwPemWSymx62OPN0tHT+Q=
196196
github.com/jesseduffield/go-git/v5 v5.14.1-0.20250407170251-e1a013310ccd/go.mod h1:lRhCiBr6XjQrvcQVa+UYsy/99d3wMXn/a0nSQlhnhlA=
197-
github.com/jesseduffield/gocui v0.3.1-0.20250529123049-319bd37ff248 h1:kFWTUOjkyuerq8L74MyTnpBvrBxPR4T5GpkOv/gr6/o=
198-
github.com/jesseduffield/gocui v0.3.1-0.20250529123049-319bd37ff248/go.mod h1:sLIyZ2J42R6idGdtemZzsiR3xY5EF0KsvYEGh3dQv3s=
197+
github.com/jesseduffield/gocui v0.3.1-0.20250605111917-fc5387961412 h1:8z1CpdCy9nzdj47lSLbDbCVmR5MgXsknYsuuHpzYk5M=
198+
github.com/jesseduffield/gocui v0.3.1-0.20250605111917-fc5387961412/go.mod h1:sLIyZ2J42R6idGdtemZzsiR3xY5EF0KsvYEGh3dQv3s=
199199
github.com/jesseduffield/kill v0.0.0-20250101124109-e216ddbe133a h1:UDeJ3EBk04bXDLOPvuqM3on8HvyJfISw0+UMqW+0a4g=
200200
github.com/jesseduffield/kill v0.0.0-20250101124109-e216ddbe133a/go.mod h1:FSWDLKT0NQpntbDd1H3lbz51fhCVlMzy/J0S6nM727Q=
201201
github.com/jesseduffield/lazycore v0.0.0-20221012050358-03d2e40243c5 h1:CDuQmfOjAtb1Gms6a1p5L2P8RhbLUq5t8aL7PiQd2uY=

pkg/gui/layout.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
package gui
22

33
import (
4+
"errors"
5+
46
"github.com/jesseduffield/gocui"
57
"github.com/jesseduffield/lazygit/pkg/gui/types"
68
"github.com/samber/lo"
@@ -121,7 +123,7 @@ func (gui *Gui) layout(g *gocui.Gui) error {
121123
}
122124

123125
_, err := setViewFromDimensions(context)
124-
if err != nil && !gocui.IsUnknownView(err) {
126+
if err != nil && !errors.Is(err, gocui.ErrUnknownView) {
125127
return err
126128
}
127129
}
@@ -134,7 +136,7 @@ func (gui *Gui) layout(g *gocui.Gui) error {
134136

135137
for _, context := range gui.transientContexts() {
136138
view, err := gui.g.View(context.GetViewName())
137-
if err != nil && !gocui.IsUnknownView(err) {
139+
if err != nil && !errors.Is(err, gocui.ErrUnknownView) {
138140
return err
139141
}
140142
view.Visible = gui.helpers.Window.GetViewNameForWindow(context.GetWindowName()) == context.GetViewName()

pkg/gui/views.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package gui
22

33
import (
4+
"errors"
45
"fmt"
56

67
"github.com/jesseduffield/gocui"
@@ -78,7 +79,7 @@ func (gui *Gui) createAllViews() error {
7879
var err error
7980
for _, mapping := range gui.orderedViewNameMappings() {
8081
*mapping.viewPtr, err = gui.prepareView(mapping.name)
81-
if err != nil && !gocui.IsUnknownView(err) {
82+
if err != nil && !errors.Is(err, gocui.ErrUnknownView) {
8283
return err
8384
}
8485
}

pkg/integration/clients/tui.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package clients
22

33
import (
4+
"errors"
45
"fmt"
56
"log"
67
"os"
@@ -314,7 +315,7 @@ func (self *app) layout(g *gocui.Gui) error {
314315
g.FgColor = gocui.ColorGreen
315316
listView, err := g.SetView("list", 0, 0, maxX-1, maxY-descriptionViewHeight-keybindingsViewHeight-editorViewHeight-1, 0)
316317
if err != nil {
317-
if !gocui.IsUnknownView(err) {
318+
if !errors.Is(err, gocui.ErrUnknownView) {
318319
return err
319320
}
320321

@@ -334,7 +335,7 @@ func (self *app) layout(g *gocui.Gui) error {
334335

335336
descriptionView, err := g.SetViewBeneath("description", "list", descriptionViewHeight)
336337
if err != nil {
337-
if !gocui.IsUnknownView(err) {
338+
if !errors.Is(err, gocui.ErrUnknownView) {
338339
return err
339340
}
340341
descriptionView.Title = "Test description"
@@ -344,7 +345,7 @@ func (self *app) layout(g *gocui.Gui) error {
344345

345346
keybindingsView, err := g.SetViewBeneath("keybindings", "description", keybindingsViewHeight)
346347
if err != nil {
347-
if !gocui.IsUnknownView(err) {
348+
if !errors.Is(err, gocui.ErrUnknownView) {
348349
return err
349350
}
350351
keybindingsView.Title = "Keybindings"
@@ -355,7 +356,7 @@ func (self *app) layout(g *gocui.Gui) error {
355356

356357
editorView, err := g.SetViewBeneath("editor", "keybindings", editorViewHeight)
357358
if err != nil {
358-
if !gocui.IsUnknownView(err) {
359+
if !errors.Is(err, gocui.ErrUnknownView) {
359360
return err
360361
}
361362

vendor/github.com/jesseduffield/gocui/gui.go

Lines changed: 12 additions & 24 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/modules.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,7 @@ github.com/jesseduffield/go-git/v5/utils/merkletrie/internal/frame
227227
github.com/jesseduffield/go-git/v5/utils/merkletrie/noder
228228
github.com/jesseduffield/go-git/v5/utils/sync
229229
github.com/jesseduffield/go-git/v5/utils/trace
230-
# github.com/jesseduffield/gocui v0.3.1-0.20250529123049-319bd37ff248
230+
# github.com/jesseduffield/gocui v0.3.1-0.20250605111917-fc5387961412
231231
## explicit; go 1.12
232232
github.com/jesseduffield/gocui
233233
# github.com/jesseduffield/kill v0.0.0-20250101124109-e216ddbe133a

0 commit comments

Comments
 (0)