Cleanup: rename a badly named function

We used the term "change line" to mean "a line that was added or deleted", but
it sounded like a verb in the function name.

Author: stefanhaller

pkg/gui/controllers/patch_building_controller.go

@@ -134,7 +134,7 @@ func (self *PatchBuildingController) toggleSelection() error {
 	state := self.context().GetState()
 
 	// Get added/deleted lines in the selected patch range
-	lineIndicesToToggle := state.ChangeLinesInSelectedPatchRange()
+	lineIndicesToToggle := state.LineIndicesOfAddedOrDeletedLinesInSelectedPatchRange()
 	if len(lineIndicesToToggle) == 0 {
 		// Only context lines or header lines selected, so nothing to do
 		return nil

pkg/gui/patch_exploring/state.go

@@ -335,7 +335,7 @@ func (s *State) SelectedPatchRange() (int, int) {
 }
 
 // Returns the line indices of the selected patch range that are changes (i.e. additions or deletions)
-func (s *State) ChangeLinesInSelectedPatchRange() []int {
+func (s *State) LineIndicesOfAddedOrDeletedLinesInSelectedPatchRange() []int {
 	viewStart, viewEnd := s.SelectedViewRange()
 	patchStart, patchEnd := s.patchLineIndices[viewStart], s.patchLineIndices[viewEnd]
 	lines := s.patch.Lines()