Skip to content

Commit f75c0af

Browse files
brandondongstefanhaller
authored andcommitted
Update disabled message
1 parent 2db0a02 commit f75c0af

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

pkg/gui/controllers/files_controller.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1223,7 +1223,7 @@ func (self *FilesController) canRemove(selectedNodes []*filetree.FileNode) *type
12231223
return nil
12241224
})
12251225
if uniqueSelectedSubmodules.Len() > 0 && (hasFiles || uniqueSelectedSubmodules.Len() > 1) {
1226-
return &types.DisabledReason{Text: self.c.Tr.RangeSelectNotSupportedForSubmodules}
1226+
return &types.DisabledReason{Text: self.c.Tr.MultiSelectNotSupportedForSubmodules}
12271227
}
12281228
}
12291229

pkg/i18n/english.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -845,7 +845,7 @@ type TranslationSet struct {
845845
NoItemSelected string
846846
SelectedItemIsNotABranch string
847847
SelectedItemDoesNotHaveFiles string
848-
RangeSelectNotSupportedForSubmodules string
848+
MultiSelectNotSupportedForSubmodules string
849849
OldCherryPickKeyWarning string
850850
CommandDoesNotSupportOpeningInEditor string
851851
CustomCommands string
@@ -1889,7 +1889,7 @@ func EnglishTranslationSet() *TranslationSet {
18891889
NoItemSelected: "No item selected",
18901890
SelectedItemIsNotABranch: "Selected item is not a branch",
18911891
SelectedItemDoesNotHaveFiles: "Selected item does not have files to view",
1892-
RangeSelectNotSupportedForSubmodules: "Range select not supported for submodules",
1892+
MultiSelectNotSupportedForSubmodules: "Multiselection not supported for submodules",
18931893
OldCherryPickKeyWarning: "The 'c' key is no longer the default key for copying commits to cherry pick. Please use `{{.copy}}` instead (and `{{.paste}}` to paste). The reason for this change is that the 'v' key for selecting a range of lines when staging is now also used for selecting a range of lines in any list view, meaning that we needed to find a new key for pasting commits, and if we're going to now use `{{.paste}}` for pasting commits, we may as well use `{{.copy}}` for copying them. If you want to configure the keybindings to get the old behaviour, set the following in your config:\n\nkeybinding:\n universal:\n toggleRangeSelect: <something other than v>\n commits:\n cherryPickCopy: 'c'\n pasteCommits: 'v'",
18941894
CommandDoesNotSupportOpeningInEditor: "This command doesn't support switching to the editor",
18951895
CustomCommands: "Custom commands",

pkg/integration/tests/submodule/reset.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ var Reset = NewIntegrationTest(NewIntegrationTestArgs{
7575
Equals(" M my_submodule_path (submodule)"),
7676
Equals(" ?? other_file").IsSelected(),
7777
).
78-
// Verify we can't use range select on submodules
78+
// Verify we can't reset a submodule and file change at the same time.
7979
Press(keys.Universal.ToggleRangeSelect).
8080
SelectPreviousItem().
8181
Lines(
@@ -85,7 +85,7 @@ var Reset = NewIntegrationTest(NewIntegrationTestArgs{
8585
).
8686
Press(keys.Universal.Remove).
8787
Tap(func() {
88-
t.ExpectToast(Contains("Disabled: Range select not supported for submodules"))
88+
t.ExpectToast(Contains("Disabled: Multiselection not supported for submodules"))
8989
}).
9090
Press(keys.Universal.ToggleRangeSelect).
9191
Lines(

pkg/integration/tests/submodule/reset_folder.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ var ResetFolder = NewIntegrationTest(NewIntegrationTestArgs{
3333
// Verify we cannot reset the entire folder (has nested file and submodule changes).
3434
Press(keys.Universal.Remove).
3535
Tap(func() {
36-
t.ExpectToast(Contains("Disabled: Range select not supported for submodules"))
36+
t.ExpectToast(Contains("Disabled: Multiselection not supported for submodules"))
3737
}).
3838
// Verify we cannot reset submodule + file or submodule + submodule via range select.
3939
SelectNextItem().
@@ -47,7 +47,7 @@ var ResetFolder = NewIntegrationTest(NewIntegrationTestArgs{
4747
).
4848
Press(keys.Universal.Remove).
4949
Tap(func() {
50-
t.ExpectToast(Contains("Disabled: Range select not supported for submodules"))
50+
t.ExpectToast(Contains("Disabled: Multiselection not supported for submodules"))
5151
}).
5252
Press(keys.Universal.ToggleRangeSelect).
5353
Press(keys.Universal.ToggleRangeSelect).
@@ -60,7 +60,7 @@ var ResetFolder = NewIntegrationTest(NewIntegrationTestArgs{
6060
).
6161
Press(keys.Universal.Remove).
6262
Tap(func() {
63-
t.ExpectToast(Contains("Disabled: Range select not supported for submodules"))
63+
t.ExpectToast(Contains("Disabled: Multiselection not supported for submodules"))
6464
}).
6565
// Reset the file change.
6666
Press(keys.Universal.ToggleRangeSelect).
@@ -81,7 +81,7 @@ var ResetFolder = NewIntegrationTest(NewIntegrationTestArgs{
8181
// Verify we still cannot reset the entire folder (has two submodule changes).
8282
Press(keys.Universal.Remove).
8383
Tap(func() {
84-
t.ExpectToast(Contains("Disabled: Range select not supported for submodules"))
84+
t.ExpectToast(Contains("Disabled: Multiselection not supported for submodules"))
8585
}).
8686
// Reset one of the submodule changes.
8787
SelectNextItem().

0 commit comments

Comments
 (0)