feat: update keybind precedence in menu

1. essentials (select, confirm, escape and prev/next item navigation)
2. menu bindings
3. outer context bindings (files, commits, etc.)

Author: HerrNaN

pkg/gui/context/menu_context.go

@@ -193,23 +193,43 @@ func (self *MenuViewModel) GetNonModelItems() []*NonModelItem {
 }
 
 func (self *MenuContext) GetKeybindings(opts types.KeybindingsOpts) []*types.Binding {
-	basicBindings := self.ListContextTrait.GetKeybindings(opts)
-	menuItemsWithKeys := lo.Filter(self.menuItems, func(item *types.MenuItem, _ int) bool {
-		return item.Key != nil
+	allBindings := self.ListContextTrait.GetKeybindings(opts)
+
+	// Define essential keys that should always work (select, confirm, escape, and prev/next item navigation)
+	essentialKeys := []types.Key{
+		opts.GetKey(opts.Config.Universal.Select),
+		opts.GetKey(opts.Config.Universal.ConfirmMenu),
+		opts.GetKey(opts.Config.Universal.Return),
+		opts.GetKey(opts.Config.Universal.PrevItem),
+		opts.GetKey(opts.Config.Universal.PrevItemAlt),
+		opts.GetKey(opts.Config.Universal.NextItem),
+		opts.GetKey(opts.Config.Universal.NextItemAlt),
+	}
+
+	// Group bindings by whether they're essential or not
+	bindingsByPriority := lo.GroupBy(allBindings, func(binding *types.Binding) bool {
+		return lo.Contains(essentialKeys, binding.Key)
 	})
 
-	menuItemBindings := lo.Map(menuItemsWithKeys, func(item *types.MenuItem, _ int) *types.Binding {
+	essentialBindings := bindingsByPriority[true]
+	navigationBindings := bindingsByPriority[false]
+
+	// Create bindings for menu items
+	menuItemBindings := lo.FilterMap(self.menuItems, func(item *types.MenuItem, _ int) (*types.Binding, bool) {
+		if item.Key == nil {
+			return nil, false
+		}
 		return &types.Binding{
 			Key:     item.Key,
 			Handler: func() error { return self.OnMenuPress(item) },
-		}
+		}, true
 	})
 
-	// appending because that means the menu item bindings have lower precedence.
-	// So if a basic binding is to escape from the menu, we want that to still be
-	// what happens when you press escape. This matters when we're showing the menu
-	// for all keybindings of say the files context.
-	return append(basicBindings, menuItemBindings...)
+	// Precedence order: essential bindings (select/confirm/escape/up/down) have highest priority,
+	// then menu item bindings, then other navigation bindings (page up/down/scroll/etc) have lowest priority.
+	// This allows menu items to override non-essential navigation keys while keeping core menu
+	// operations (like escape to close, enter to select, up/down to navigate) always available.
+	return append(append(essentialBindings, menuItemBindings...), navigationBindings...)
 }
 
 func (self *MenuContext) OnMenuPress(selectedItem *types.MenuItem) error {