Is there any way to customize "open" or "editAtLine" and pass a commit hash?

[Blankeos]

Currently, Zed just released https://x.com/zeddotdev/status/1910053786787430745 v0.181.5 - Supports viewing Files in Zed from an old commit hash.

Though I'm not aware of any CLI args to open diffs via a commandline with Zed (yet) (i.e. zed {{filename}} --diff "{{hash}}..{{hash}}". I do think that once it's possible, I was thinking it would be super convenient if Lazygit can integrate with it by also passing a {{commit_hash}} in the os.open and os.editAtLine and os.editAtLineAndWait so it can integrate with Zed better.

Currently this is what is possible with Lazygit + Zed:

os:
  open: "zed {{filename}}"
  edit: "zed {{filename}}"
  editAtLine: "zed {{filename}}:{{line}}"
  editAtLineAndWait: "zed {{filename}}:{{line}} --wait"
  openDirInEditor: "zed {{filename}}"

Maybe in the future, this might be possible too:

os:
  open: "zed {{filename}} --diff {{commit_hash..HEAD}}"
  editAtLine: "zed {{filename}} --diff {{commit_hash..HEAD}}"

I was reading the Configuration guide but I couldn't really find anything on passing the commit_hash (if it was possible).

Thanks in advance guys!

[stefanhaller]

I don't want to change the meaning of the e and o commands; these should continue to open the file in the current working copy, it would break people's workflows if we changed that. This was discussed several times, e.g. here.

I'm not sure why you want to open a diff in zed, but it seems to me that this should be easy to accomplish with a custom command. I don't feel that this is something we should build into lazygit, but again, I'm not sure I understand what your proposed workflow would be, or what problems it would solve.

[Blankeos]

Thanks for responding! To make it simpler, I guess the specific use case is "Open an older version of a file based on its commit hash"

• VSCode + Git Graph Extension (Possible)

vscode-gitgraph-open-old-file.mp4

• Zed + Lazygit (Not possible)

zed-lazygit.mp4

What makes it not possible is two things at the moment:

1. Zed - doesn't have a way to open an old version of the file via CLI. But it currently can within the editor by clicking the commit hash from a blame. (I am hoping they add something).
2. Lazygit - only has two variables (I think):
   • {{filename}} Available with e and o.
   • {{line}} Available with e.

Current behavior in Lazygit is that when I press e or o while my cursor is on a file from a previous commit, it opens the existing latest file in Zed via (zed {{filename}}. But it doesn't work if:

• The file is already deleted.
• I want to see an older version of it.

Hence maybe, Lazygit could add another variable {{hash}} or something (maybe I'm just not familiar if there already is).

---

I'm not sure why you want to open a diff in zed

The reason is so that I don't context-switch when exploring an older version of the file from previous commits. I do know this is already possible in Lazygit's UI using just enter. Though it is sufficient, there isn't syntax highlighting (which is minor) and it has different controls for exploring the buffer, compared to Zed (where I will be more used at navigating different hunks, text wrapping, buffer search, etc). VSCode can do it.

I don't want to change the meaning of the e and o commands; (...) it would break people's workflows if we changed that.

I don't see how it would break people's workflows if an additional {{hash}} variable was just added for os.open or os.editAtLine so it's configurable for this usecase? Users who don't configure will have the same workflow. They can either use: zed {{filename}} or zed {{filename}}#{{hash}} if they choose to do so or something.

I also have no problems with not changing the meaning of e and o commands actually. Thanks for sharing about the custom command. I am curious though... is it possible to access the hash of the commit/file I trigerred with that?