Skip to content

Commit 254e7cd

Browse files
authored
Fix UI Tests on GH Actions (#149)
All tests run and pass for me locally. But GH Actions fails.
1 parent f260992 commit 254e7cd

File tree

4 files changed

+10
-13
lines changed

4 files changed

+10
-13
lines changed

Example/Tests/UITests/GridUITests.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,13 +20,13 @@ final class GridUITests: XCTestCase, @unchecked Sendable {
2020
try await super.setUp()
2121
self.continueAfterFailure = false
2222
await self.app.launch()
23+
await self.app.activate()
2324
}
2425

2526
@MainActor
2627
func test_grid_shuffle() {
27-
self.app.activate()
28-
2928
let shuffleButton = self.app.navigationBars["Grid"].buttons["repeat"]
29+
XCTAssertTrue(shuffleButton.waitForExistence(timeout: 3))
3030

3131
for _ in 1...20 {
3232
shuffleButton.tap()
@@ -35,12 +35,12 @@ final class GridUITests: XCTestCase, @unchecked Sendable {
3535

3636
@MainActor
3737
func test_grid_remove_reset() {
38-
self.app.activate()
39-
4038
let shuffleButton = self.app.navigationBars["Grid"].buttons["repeat"]
39+
XCTAssertTrue(shuffleButton.waitForExistence(timeout: 3))
4140
shuffleButton.tap()
4241

4342
let resetButton = self.app.navigationBars["Grid"].buttons["Refresh"]
43+
XCTAssertTrue(resetButton.waitForExistence(timeout: 3))
4444
resetButton.tap()
4545

4646
let collectionViewsQuery = self.app.collectionViews

Example/Tests/UITests/ListUITests.swift

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,15 @@ final class ListUITests: XCTestCase, @unchecked Sendable {
2020
try await super.setUp()
2121
self.continueAfterFailure = false
2222
await self.app.launch()
23+
await self.app.activate()
2324
}
2425

2526
@MainActor
2627
func test_list_shuffle() {
27-
self.app.activate()
28-
2928
self.app.tabBars["Tab Bar"].buttons["List"].tap()
3029

3130
let shuffleButton = self.app.navigationBars["List"].buttons["repeat"]
31+
XCTAssertTrue(shuffleButton.waitForExistence(timeout: 3))
3232

3333
for _ in 1...20 {
3434
shuffleButton.tap()
@@ -37,14 +37,14 @@ final class ListUITests: XCTestCase, @unchecked Sendable {
3737

3838
@MainActor
3939
func test_list_remove_reset() {
40-
self.app.activate()
41-
4240
self.app.tabBars["Tab Bar"].buttons["List"].tap()
4341

4442
let shuffleButton = self.app.navigationBars["List"].buttons["repeat"]
43+
XCTAssertTrue(shuffleButton.waitForExistence(timeout: 3))
4544
shuffleButton.tap()
4645

4746
let resetButton = self.app.navigationBars["List"].buttons["Refresh"]
47+
XCTAssertTrue(resetButton.waitForExistence(timeout: 3))
4848
resetButton.tap()
4949

5050
let collectionViewsQuery = self.app.collectionViews

Example/Tests/UITests/StaticViewUITests.swift

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,20 +20,17 @@ final class StaticViewUITests: XCTestCase, @unchecked Sendable {
2020
try await super.setUp()
2121
self.continueAfterFailure = false
2222
await self.app.launch()
23+
await self.app.activate()
2324
}
2425

2526
@MainActor
2627
func test_view_other_tabs() {
27-
self.app.activate()
28-
XCTAssertTrue(true)
29-
3028
self.app.tabBars["Tab Bar"].buttons["Simple Static"].tap()
3129
self.app.collectionViews["Simple Static"].swipeUp()
3230
self.app.collectionViews["Simple Static"].swipeDown()
3331

3432
self.app.tabBars["Tab Bar"].buttons["Flow Layout"].tap()
3533
self.app.collectionViews["Flow Layout"].swipeUp()
3634
self.app.collectionViews["Flow Layout"].swipeDown()
37-
3835
}
3936
}

Tests/Utils/XCTestCase+Extensions.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ extension XCTestCase {
2424
}
2525

2626
func expectation(function: String = #function, name: String? = nil) -> XCTestExpectation {
27-
self.expectation(description: [function, name].compactMap { $0 }.joined(separator: "-"))
27+
self.expectation(description: [function, name].compactMap(\.self).joined(separator: "-"))
2828
}
2929

3030
func expectation(field: TestExpectationField, id: UniqueIdentifier, function: String = #function) -> XCTestExpectation {

0 commit comments

Comments
 (0)