Skip to content

Commit 2879920

Browse files
xfumihiroSimenB
authored andcommitted
fix: add null guards on argument selectors
Closes #28
1 parent 7673c54 commit 2879920

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

rules/__tests__/prefer_to_be_undefined.test.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ ruleTester.run('prefer_to_be_undefined', rules['prefer-to-be-undefined'], {
99
valid: [
1010
'expect(undefined).toBeUndefined();',
1111
'expect(true).not.toBeUndefined();',
12+
'expect({}).toEqual({});',
13+
'expect(null).toEqual(null);',
1214
],
1315

1416
invalid: [

rules/util.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,26 +27,30 @@ const expectToBeCase = (node, arg) =>
2727
expectCase(node) &&
2828
methodName(node) === 'toBe' &&
2929
argument(node) &&
30-
argument(node).value === arg;
30+
argument(node).value === arg &&
31+
(arg === null || argument(node).name);
3132

3233
const expectNotToBeCase = (node, arg) =>
3334
expectNotCase(node) &&
3435
methodName2(node) === 'toBe' &&
3536
argument2(node) &&
36-
argument2(node).value === arg;
37+
argument2(node).value === arg &&
38+
(arg === null || argument2(node).name);
3739

3840
const expectToEqualCase = (node, arg) =>
3941
!(expectNotCase(node) || expectResolveCase(node) || expectRejectCase(node)) &&
4042
expectCase(node) &&
4143
methodName(node) === 'toEqual' &&
4244
argument(node) &&
43-
argument(node).value === arg;
45+
argument(node).value === arg &&
46+
(arg === null || argument(node).name);
4447

4548
const expectNotToEqualCase = (node, arg) =>
4649
expectNotCase(node) &&
4750
methodName2(node) === 'toEqual' &&
4851
argument2(node) &&
49-
argument2(node).value === arg;
52+
argument2(node).value === arg &&
53+
(arg === null || argument2(node).name);
5054

5155
const expectToBeUndefinedCase = node =>
5256
!(expectNotCase(node) || expectResolveCase(node) || expectRejectCase(node)) &&

0 commit comments

Comments
 (0)